Sponsored Content
Skip to content

Decouple app/tx from Application and Config - #6227

Merged
bthomee merged 72 commits into
developfrom
a1q123456/decouple-app-tx-with-application
Feb 17, 2026
Merged

Decouple app/tx from Application and Config#6227
bthomee merged 72 commits into
developfrom
a1q123456/decouple-app-tx-with-application

Conversation

@a1q123456

@a1q123456 a1q123456 commented Jan 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR decouples app/tx with Application and Config to clear the way to moving transactors to libxrpl.

This PR is part of the modularisation of the transactors. See all PRs here:

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@a1q123456
Add ServiceRegistry to help migration.
1156fa2 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Fix the levelization error
5ff7222 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Modularise WalletDB and Manifest
4e554cc 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Fix the build error
755ba31 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Fix the levelization error
c9dbea1 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Move LedgerShortcut to libxrpl.protocol as it's a protocol thing
65a85ae 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Modularise RelationalDatabase
5253380
@a1q123456
Fix the levelization error
cf67641 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 requested a review from a team January 15, 2026 14:52
@a1q123456
Fix the build error
f420b2e 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 force-pushed the a1q123456/modularise-hashrouter-conditions-and-orderbookdb branch from fb39fa3 to 5733073 Compare January 15, 2026 15:05
@a1q123456
a1q123456 force-pushed the a1q123456/decouple-app-tx-with-application branch 2 times, most recently from fa276cf to d4e5749 Compare January 15, 2026 15:11
@a1q123456
Fix build error
2db165a 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Fix build error
12e5129 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 force-pushed the a1q123456/modularise-hashrouter-conditions-and-orderbookdb branch from 4d15d4e to 1029221 Compare January 15, 2026 15:55
@a1q123456
a1q123456 force-pushed the a1q123456/decouple-app-tx-with-application branch from d4e5749 to ab6b416 Compare January 15, 2026 15:56
@a1q123456
Fix build error
7278f85 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Fix build error
922752a 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Move InfoSub out of rpc as it's not related to rpc handlers
3d77e7a 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Decouple NetworkOPs from app/ledger
5d0dde7
@a1q123456
Make NetworkOPs accept ServiceRegistry
51cdb4f
@a1q123456
Move the NetworkOPs interface to libxrpl
2ddd96f
@a1q123456
Fix the levelization error
44dc0ef 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 force-pushed the a1q123456/modularise-hashrouter-conditions-and-orderbookdb branch 2 times, most recently from 4e31ea1 to 1fb3a22 Compare January 15, 2026 16:34
@a1q123456
Fix the build error
a2366a1 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Fix pre-commit errors
f518dd5 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Decouple HashRouter from Config
63cbd53
@a1q123456
Move HashRouter to libxrpl
acf38c7
@a1q123456
Restore the order
5004ef1 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 force-pushed the a1q123456/decouple-app-tx-with-application branch from 899246d to a934d42 Compare February 13, 2026 11:46
@a1q123456
Merge branch 'a1q123456/modularise-hashrouter-conditions-and-orderboo…
8d0f791 
…kdb' into a1q123456/decouple-app-tx-with-application

Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 force-pushed the a1q123456/decouple-app-tx-with-application branch from a934d42 to 8d0f791 Compare February 13, 2026 11:48
@a1q123456
Fix build errors
2b0ec4b 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Fix levelisation
d554280 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Merge branch 'a1q123456/modularise-hashrouter-conditions-and-orderboo…
3e4a359 
…kdb' into a1q123456/decouple-app-tx-with-application
@a1q123456
Restore file
3abf3fc 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Restore file
28aad99 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Fix build errors
ce334a9 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
vlntb
vlntb reviewed Feb 13, 2026
View reviewed changes

@vlntb vlntb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Two nit suggestions.

Comment thread src/xrpld/core/NetworkIDServiceImpl.h Outdated
Comment thread include/xrpl/core/NetworkIDService.h Outdated
@a1q123456
Address PR comments
f747dcb 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
Base automatically changed from a1q123456/modularise-hashrouter-conditions-and-orderbookdb to develop February 13, 2026 15:34
@a1q123456
Merge remote-tracking branch 'origin/develop' into a1q123456/decouple…
dc0e61c 
…-app-tx-with-application

Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Fix levelisation
a6088ff 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 requested a review from vlntb February 13, 2026 15:49
bthomee
bthomee reviewed Feb 13, 2026
View reviewed changes
Comment thread src/xrpld/core/detail/NetworkIDServiceImpl.cpp Outdated
@a1q123456
Address PR comments
acbec5f 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 requested a review from bthomee February 17, 2026 13:46
@a1q123456 a1q123456 added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Feb 17, 2026
@a1q123456 a1q123456 changed the title Decouple app/tx with Application and Config Decouple app/tx from Application and Config Feb 17, 2026
@bthomee
bthomee merged commit 3624011 into develop Feb 17, 2026
3 checks passed
@bthomee
bthomee deleted the a1q123456/decouple-app-tx-with-application branch February 17, 2026 16:29
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
@a1q123456
refactor: Decouple app/tx from Application and Config (XRPLF#6227)
a8d1887 
This change decouples app/tx from `Application` and `Config` to clear the way to moving transactors to `libxrpl`.
This was referenced Jun 12, 2026
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@godexsoft godexsoft godexsoft approved these changes
@vlntb vlntb vlntb approved these changes
@bthomee bthomee Awaiting requested review from bthomee

Assignees

No one assigned

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@a1q123456 @godexsoft @bthomee @vlntb @mvadari