📚 Tutorial: Modularise WalletDB and Manifest by a1q123456 · Pull Request #6223 · XRPLF/rippled · GitHub

a1q123456 · 2026-01-15T12:23:44Z

High Level Overview of Change

This PR modularises the walletdb and manifest. Please be aware that the wallet db actually has nothing to do with account wallets and it stores node configuration, which is why it depends on Manifest.

Context of Change

To help modularisation, the wallet db has to be modularised.

This PR is part of the modularisation of the transactors. See all PRs here:
#6222
#6223
#6224
#6225
#6226
#6227
#6228

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (non-breaking change that only restructures code)
Performance (increase or change in throughput and/or latency)
Tests (you added tests for code that already exists, or your new feature included in this PR)
Documentation update
Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
Release

codecov · 2026-01-15T14:34:01Z

Codecov Report

❌ Patch coverage is 86.76471% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.9%. Comparing base (e11f619) to head (e6725f3).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/libxrpl/rdb/DatabaseCon.cpp	64.3%	10 Missing ⚠️
...rc/xrpld/app/rdb/backend/detail/SQLiteDatabase.cpp	65.0%	7 Missing ⚠️
src/xrpld/core/detail/Config.cpp	98.6%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #6223     +/-   ##
=========================================
- Coverage     79.9%   79.9%   -0.0%     
=========================================
  Files          840     840             
  Lines        65514   65522      +8     
  Branches      7269    7249     -20     
=========================================
+ Hits         52360   52362      +2     
- Misses       13154   13160      +6

Files with missing lines	Coverage Δ
include/xrpl/core/PeerReservationTable.h	`25.0% <ø> (ø)`
include/xrpl/core/ServiceRegistry.h	`100.0% <ø> (ø)`
include/xrpl/core/StartUpType.h	`100.0% <100.0%> (ø)`
include/xrpl/rdb/DatabaseCon.h	`100.0% <100.0%> (ø)`
include/xrpl/rdb/SociDB.h	`100.0% <ø> (ø)`
include/xrpl/server/Manifest.h	`79.2% <ø> (ø)`
src/libxrpl/rdb/SociDB.cpp	`60.7% <ø> (ø)`
src/libxrpl/server/State.cpp	`88.1% <ø> (ø)`
src/libxrpl/server/Vacuum.cpp	`0.0% <ø> (ø)`
src/libxrpl/server/Wallet.cpp	`75.9% <ø> (ø)`
... and 21 more

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

godexsoft

Leaving some suggestions.

godexsoft · 2026-02-04T11:24:01Z

+    isStopping() const = 0;
+
+    virtual beast::Journal
+    journal(std::string const& name) = 0;


this should be getJournal and getLog to match other service locator accessors (maybe in another pr)

This is going to be a big PR https://github.com/XRPLF/rippled/pull/new/a1q123456/rename-xxx-to-getXxx

Signed-off-by: JCW <a1q123456@users.noreply.github.com>

pratikmankawde · 2026-02-04T18:33:38Z

+                }
+                else
+                {
+                    Throw<std::runtime_error>("Invalid journal_mode value: " + journal_mode);


Do we really want to terminate if journal_mode is invalid? Should it not revert to a default value?

Same, I don't think we should correct anything and try to hide the problem here.

pratikmankawde · 2026-02-04T18:35:07Z

+                // #synchronous Valid values : off, normal, full, extra
+                if (set(synchronous, "synchronous", sqlite) && !safety_level.empty())
+                {
+                    Throw<std::runtime_error>(


Shouldn't we log these errors instead and continue with a default correct combination of values?

I don't think so. If the user input is wrong, we definitely want the user to correct it. The user may be surprised otherwise.

pratikmankawde

Left some comments.

godexsoft

LGTM for a refactoring PR 👍
Please create issues for everything that has been noted by @pratikmankawde and myself.

a1q123456 · 2026-02-10T16:02:30Z

RIPD-4880 Ticket created.

pratikmankawde

Approved with one suggestion about cleaning up the lambda in src/xrpld/core/detail/Config.cpp::setup_Databasecon(..)

…se-wallet-db-and-manifest

Signed-off-by: JCW <a1q123456@users.noreply.github.com>

This change modularizes the `WalletDB` and `Manifest`. Note that the wallet db has nothing to do with account wallets and it stores node configuration, which is why it depends on the manifest code.

a1q123456 requested a review from a team January 15, 2026 12:23

a1q123456 changed the title ~~A1q123456/modularise wallet db and manifest~~ Modularise wallet db and manifest Jan 15, 2026

a1q123456 changed the title ~~Modularise wallet db and manifest~~ Modularise WalletDB and Manifest Jan 15, 2026

a1q123456 force-pushed the a1q123456/modularise-wallet-db-and-manifest branch from af0b679 to 4e554cc Compare January 15, 2026 13:22

a1q123456 requested review from godexsoft and pratikmankawde January 15, 2026 13:22

a1q123456 force-pushed the a1q123456/add_service_registry branch 3 times, most recently from 7c5faca to 09b52e4 Compare February 3, 2026 16:23

a1q123456 force-pushed the a1q123456/modularise-wallet-db-and-manifest branch from c9dbea1 to 8dc9483 Compare February 3, 2026 16:43

Base automatically changed from a1q123456/add_service_registry to develop February 3, 2026 19:08

a1q123456 force-pushed the a1q123456/modularise-wallet-db-and-manifest branch 2 times, most recently from 572f5b2 to 650dc4f Compare February 4, 2026 11:27

godexsoft requested changes Feb 4, 2026

View reviewed changes

a1q123456 requested a review from godexsoft February 4, 2026 13:27

a1q123456 added 6 commits February 4, 2026 15:11

Modularise WalletDB and Manifest

873f7a6

Signed-off-by: JCW <a1q123456@users.noreply.github.com>

Fix the build error

cf70675

Signed-off-by: JCW <a1q123456@users.noreply.github.com>

Fix the levelization error

e800eb1

Signed-off-by: JCW <a1q123456@users.noreply.github.com>

Fix levelization errors

5136edc

Signed-off-by: JCW <a1q123456@users.noreply.github.com>

Fix errors

4586b6d

Signed-off-by: JCW <a1q123456@users.noreply.github.com>

Address comments

23bbeb4

Signed-off-by: JCW <a1q123456@users.noreply.github.com>

a1q123456 force-pushed the a1q123456/modularise-wallet-db-and-manifest branch from 0dd8b72 to b3f0361 Compare February 4, 2026 15:11

Fix build errors

c0bbbb2

Signed-off-by: JCW <a1q123456@users.noreply.github.com>

a1q123456 force-pushed the a1q123456/modularise-wallet-db-and-manifest branch from b3f0361 to c0bbbb2 Compare February 4, 2026 15:30

pratikmankawde reviewed Feb 4, 2026

View reviewed changes

Comment thread src/libxrpl/rdb/DatabaseCon.cpp

pratikmankawde reviewed Feb 4, 2026

View reviewed changes

Comment thread src/libxrpl/rdb/DatabaseCon.cpp

pratikmankawde reviewed Feb 4, 2026

View reviewed changes

Comment thread src/xrpld/core/detail/Config.cpp Outdated

pratikmankawde reviewed Feb 4, 2026

View reviewed changes

Comment thread src/xrpld/core/detail/Config.cpp Outdated

a1q123456 requested a review from pratikmankawde February 5, 2026 12:25

godexsoft approved these changes Feb 10, 2026

View reviewed changes

Comment thread src/libxrpl/rdb/DatabaseCon.cpp

pratikmankawde approved these changes Feb 11, 2026

View reviewed changes

a1q123456 added 2 commits February 11, 2026 11:51

Merge remote-tracking branch 'origin/develop' into a1q123456/modulari…

daa04b6

…se-wallet-db-and-manifest

Address a PR comment

e6725f3

Signed-off-by: JCW <a1q123456@users.noreply.github.com>

a1q123456 added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Feb 11, 2026

bthomee enabled auto-merge (squash) February 11, 2026 13:27

bthomee merged commit ef28469 into develop Feb 11, 2026
1 check passed

bthomee deleted the a1q123456/modularise-wallet-db-and-manifest branch February 11, 2026 13:42

a1q123456 added a commit that referenced this pull request Feb 19, 2026

Address PR comments in #6223

376be0d

Signed-off-by: JCW <a1q123456@users.noreply.github.com>

mvadari added this to the 3.2.0 milestone May 20, 2026

Uh oh!

Conversation

a1q123456 commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

High Level Overview of Change

Context of Change

Type of Change

Uh oh!

codecov Bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

godexsoft left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

godexsoft Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

a1q123456 Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pratikmankawde Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

a1q123456 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

pratikmankawde Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

a1q123456 Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

pratikmankawde left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

godexsoft left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

a1q123456 commented Feb 10, 2026

Uh oh!

pratikmankawde left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

a1q123456 commented Jan 15, 2026 •

edited

Loading

codecov Bot commented Jan 15, 2026 •

edited

Loading

pratikmankawde Feb 4, 2026 •

edited

Loading