Sponsored Content
Skip to content

Modularise the NetworkOPs interface - #6225

Merged
bthomee merged 25 commits into
developfrom
a1q123456/modularise-networkops-interface
Feb 12, 2026
Merged

Modularise the NetworkOPs interface#6225
bthomee merged 25 commits into
developfrom
a1q123456/modularise-networkops-interface

Conversation

@a1q123456

@a1q123456 a1q123456 commented Jan 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR moves the NetworkOPs interface into libxrpl and it leaves the implementation in xrpld.

Context of Change

As the Change transaction directly replies on NetworkOPs, we have to move the interface to libxrpl before we can fully modularise transactors.

This PR is part of the modularisation of the transactors. See all PRs here:

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@a1q123456
a1q123456 requested review from a team, mathbunnyru and vvysokikh1 and removed request for a team January 15, 2026 14:30
@a1q123456
a1q123456 force-pushed the a1q123456/modularise-networkops-interface branch 3 times, most recently from 5df4f28 to 44dc0ef Compare January 15, 2026 16:27
@codecov

codecov Bot commented Jan 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.73427% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.9%. Comparing base (11e8d1f) to head (d170b9c).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/xrpld/app/misc/NetworkOPs.cpp 64.7% 49 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6225     +/-   ##
=========================================
- Coverage     79.9%   79.9%   -0.0%     
=========================================
  Files          840     840             
  Lines        65508   65513      +5     
  Branches      7248    7256      +8     
=========================================
- Hits         52354   52348      -6     
- Misses       13154   13165     +11
Files with missing lines Coverage Δ
include/xrpl/server/InfoSub.h 100.0% <ø> (ø)
include/xrpl/server/NetworkOPs.h 100.0% <ø> (ø)
src/libxrpl/server/InfoSub.cpp 95.9% <ø> (ø)
src/xrpld/app/consensus/RCLConsensus.cpp 58.1% <ø> (ø)
src/xrpld/app/ledger/BookListeners.h 100.0% <ø> (ø)
src/xrpld/app/ledger/ConsensusTransSetSF.cpp 0.0% <ø> (ø)
src/xrpld/app/ledger/OrderBookDB.cpp 80.0% <ø> (ø)
src/xrpld/app/ledger/detail/InboundLedgers.cpp 37.8% <ø> (ø)
...rc/xrpld/app/ledger/detail/InboundTransactions.cpp 48.8% <ø> (ø)
src/xrpld/app/ledger/detail/LedgerMaster.cpp 43.2% <ø> (-0.2%) ⬇️
... and 31 more

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was referenced Jan 15, 2026
Merged
Merged
Merged
Merged
Merged
Merged
@a1q123456
a1q123456 force-pushed the a1q123456/modularise-relational-db branch 3 times, most recently from eebaec1 to 860e22d Compare February 4, 2026 13:30
@a1q123456
a1q123456 force-pushed the a1q123456/modularise-networkops-interface branch 2 times, most recently from 9198b98 to b988228 Compare February 4, 2026 15:11
@a1q123456
Modularise WalletDB and Manifest
873f7a6 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Fix the build error
cf70675 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Fix the levelization error
e800eb1 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Fix levelization errors
5136edc 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Fix errors
4586b6d 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Address comments
23bbeb4 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
a1q123456 force-pushed the a1q123456/modularise-relational-db branch from 860e22d to 39f6e3a Compare February 4, 2026 15:16
@a1q123456
a1q123456 force-pushed the a1q123456/modularise-networkops-interface branch 2 times, most recently from 5718952 to 0baa058 Compare February 4, 2026 15:26
@a1q123456
Fix build errors
c0bbbb2 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Move LedgerShortcut to libxrpl.protocol as it's a protocol thing
e1cb206 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Address PR comments
5b412ea 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Merge remote-tracking branch 'origin/develop' into a1q123456/modulari…
9dbe6b9 
…se-relational-db

Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Merge branch 'a1q123456/modularise-relational-db' into a1q123456/modu…
795d01d 
…larise-networkops-interface
@a1q123456
Address a PR comment
6587547 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456 a1q123456 removed the Needs additional review PR requires at least one more code review approval before it can be merged label Feb 11, 2026
@a1q123456
a1q123456 removed the request for review from mathbunnyru February 11, 2026 14:22
@a1q123456
a1q123456 force-pushed the a1q123456/modularise-relational-db branch from 9dbe6b9 to 6ea2646 Compare February 11, 2026 15:02
pratikmankawde
pratikmankawde reviewed Feb 11, 2026
View reviewed changes
Comment thread include/xrpl/protocol/TxSearched.h
pratikmankawde
pratikmankawde reviewed Feb 11, 2026
View reviewed changes
Comment thread include/xrpl/rdb/RelationalDatabase.h
pratikmankawde
pratikmankawde reviewed Feb 11, 2026
View reviewed changes
Comment thread src/xrpld/app/misc/detail/Transaction.cpp
pratikmankawde
pratikmankawde reviewed Feb 11, 2026
View reviewed changes
Comment thread src/xrpld/app/rdb/backend/detail/SQLiteDatabase.cpp
pratikmankawde
pratikmankawde reviewed Feb 11, 2026
View reviewed changes
Comment thread src/xrpld/app/rdb/backend/SQLiteDatabase.h
pratikmankawde
pratikmankawde reviewed Feb 11, 2026
View reviewed changes
Comment thread src/xrpld/app/rdb/backend/SQLiteDatabase.h
pratikmankawde
pratikmankawde reviewed Feb 11, 2026
View reviewed changes

@pratikmankawde pratikmankawde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

Base automatically changed from a1q123456/modularise-relational-db to develop February 11, 2026 16:22
godexsoft
godexsoft approved these changes Feb 12, 2026
View reviewed changes

@godexsoft godexsoft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments and questions but nothing is really a blocker here. It's ok for the modularization job it's aiming to do.

Comment thread include/xrpl/rdb/RelationalDatabase.h

@godexsoft godexsoft Feb 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'struct' should not be needed here

@a1q123456 a1q123456 Feb 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fixed in RIPD-4880.

@a1q123456 a1q123456 Feb 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6389

Comment thread src/xrpld/app/main/Application.cpp
Comment thread src/xrpld/app/misc/NetworkOPs.cpp
Comment thread src/xrpld/app/rdb/backend/detail/SQLiteDatabase.cpp Outdated
Comment thread src/xrpld/app/rdb/backend/SQLiteDatabase.h Outdated
Comment thread src/xrpld/app/rdb/backend/SQLiteDatabase.h Outdated
Comment thread src/xrpld/app/rdb/backend/SQLiteDatabase.h
@a1q123456
Address PR comments.
54be49d 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@a1q123456
Merge remote-tracking branch 'origin/develop' into a1q123456/modulari…
ffabc97 
…se-networkops-interface

Signed-off-by: JCW <a1q123456@users.noreply.github.com>
pratikmankawde
pratikmankawde approved these changes Feb 12, 2026
View reviewed changes

@pratikmankawde pratikmankawde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a1q123456 a1q123456 added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Feb 12, 2026
@a1q123456
Address a PR comment.
1554c76 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
bthomee
bthomee reviewed Feb 12, 2026
View reviewed changes
Comment thread src/xrpld/app/misc/make_NetworkOPs.h Outdated
@a1q123456
Fix a problem.
d170b9c 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@bthomee
bthomee merged commit 5edd356 into develop Feb 12, 2026
2 of 3 checks passed
@bthomee
bthomee deleted the a1q123456/modularise-networkops-interface branch February 12, 2026 18:15
a1q123456 added a commit that referenced this pull request Feb 19, 2026
@a1q123456
Address PR comments in #6225
276fe7d 
Signed-off-by: JCW <a1q123456@users.noreply.github.com>
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
@a1q123456
refactor: Modularize the NetworkOPs interface (XRPLF#6225)
08c1ff0 
This change moves the NetworkOPs interface into `libxrpl` and it leaves its implementation in `xrpld`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bthomee bthomee bthomee left review comments
@godexsoft godexsoft godexsoft approved these changes
@pratikmankawde pratikmankawde pratikmankawde approved these changes
@kuznetsss kuznetsss kuznetsss approved these changes
+1 more reviewer
@vvysokikh1 vvysokikh1 vvysokikh1 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

7 participants

@a1q123456 @godexsoft @pratikmankawde @bthomee @kuznetsss @vvysokikh1 @mvadari