Sponsored Content
Skip to content

fix: More clang-tidy issues found after merging to develop - #6640

Merged
bthomee merged 8 commits into
XRPLF:developfrom
godexsoft:bugfix/clang-tidy-extrafix2
Mar 25, 2026
Merged

fix: More clang-tidy issues found after merging to develop#6640
bthomee merged 8 commits into
XRPLF:developfrom
godexsoft:bugfix/clang-tidy-extrafix2

Conversation

@godexsoft

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR fixes issues that did not show up before we merged #6595

API Impact

No impact.

@codecov

codecov Bot commented Mar 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.4%. Comparing base (0510ee4) to head (116b4db).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/libxrpl/ledger/helpers/RippleStateHelpers.cpp 91.7% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6640     +/-   ##
=========================================
- Coverage     81.5%   81.4%   -0.0%     
=========================================
  Files          997     997             
  Lines        74408   74410      +2     
  Branches      7561    7556      -5     
=========================================
- Hits         60607   60606      -1     
- Misses       13801   13804      +3     
Files with missing lines Coverage Δ
src/libxrpl/ledger/helpers/DirectoryHelpers.cpp 95.5% <100.0%> (ø)
src/libxrpl/ledger/helpers/TokenHelpers.cpp 93.5% <100.0%> (+<0.1%) ⬆️
src/libxrpl/ledger/helpers/RippleStateHelpers.cpp 92.4% <91.7%> (+<0.1%) ⬆️

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@godexsoft godexsoft added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 25, 2026
Comment thread .github/workflows/reusable-clang-tidy.yml Outdated
Comment thread .github/workflows/reusable-clang-tidy.yml Outdated
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
Comment thread .clang-tidy Outdated
Comment thread src/test/beast/beast_io_latency_probe_test.cpp Outdated
@godexsoft
godexsoft requested a review from mathbunnyru March 25, 2026 13:38
@bthomee
bthomee enabled auto-merge March 25, 2026 13:38
@bthomee
bthomee added this pull request to the merge queue Mar 25, 2026
Merged via the queue into XRPLF:develop with commit 403fd7c Mar 25, 2026
3 checks passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Co-authored-by: Ayaz Salikhov <mathbunnyru@users.noreply.github.com>
Co-authored-by: Bart <bthomee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants