refactor: Enable more clang-tidy readability checks - #6595
Merged
bthomee merged 17 commits intoMar 24, 2026
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #6595 +/- ##
=======================================
Coverage 81.4% 81.5%
=======================================
Files 997 997
Lines 74415 74410 -5
Branches 7561 7555 -6
=======================================
- Hits 60611 60608 -3
+ Misses 13804 13802 -2
🚀 New features to boost your workflow:
|
godexsoft
marked this pull request as ready for review
March 23, 2026 19:07
kuznetsss
approved these changes
Mar 24, 2026
kuznetsss
left a comment
Contributor
There was a problem hiding this comment.
LGTM, a few suggestions
Co-authored-by: Sergey Kuznetsov <kuzzz99@gmail.com>
Co-authored-by: Sergey Kuznetsov <kuzzz99@gmail.com>
mathbunnyru
reviewed
Mar 24, 2026
mathbunnyru
approved these changes
Mar 24, 2026
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
Co-authored-by: Sergey Kuznetsov <kuzzz99@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR enables the following checks:
For some of them NOLINTs have been added (for things like to_string or some functions that should not be static but clang-tidy insists).
The other two checks that are left (other than the huge
identifier-namingone - #6571) I think we want to leave out:Context of Change
API Impact
No impact.
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)