Sponsored Content
Skip to content

refactor: Rename transactor files/classes to match the tx name - #6580

Merged
bthomee merged 10 commits into
XRPLF:developfrom
mvadari:rename-tx-files
Mar 18, 2026
Merged

refactor: Rename transactor files/classes to match the tx name#6580
bthomee merged 10 commits into
XRPLF:developfrom
mvadari:rename-tx-files

Conversation

@mvadari

@mvadari mvadari commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR refactors the transactor code so that the transactor classes and filenames (and other artifacts like logs) match the canonical transaction names (e.g. SetTrust -> TrustSet and PayChanCreate -> PaymentChannelCreate).

Context of Change

This has been a long-time minor annoyance in this codebase, and #6483 and #6495 made this a lot easier to do.

API Impact

N/A

@mvadari
mvadari requested a review from Tapanito March 18, 2026 16:54

@Tapanito Tapanito left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a change! LGTM

@mvadari
mvadari requested review from bthomee and godexsoft March 18, 2026 17:22
@codecov

codecov Bot commented Mar 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.91667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.7%. Comparing base (804a351) to head (1bb8abb).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...c/libxrpl/tx/transactors/account/AccountDelete.cpp 90.9% 1 Missing ⚠️
src/libxrpl/tx/transactors/dex/OfferCancel.cpp 75.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6580     +/-   ##
=========================================
- Coverage     79.7%   79.7%   -0.0%     
=========================================
  Files          878     878             
  Lines        68116   68116             
  Branches      7557    7559      +2     
=========================================
- Hits         54311   54310      -1     
- Misses       13805   13806      +1     
Files with missing lines Coverage Δ
include/xrpl/protocol/detail/transactions.macro 100.0% <ø> (ø)
include/xrpl/tx/Transactor.h 100.0% <ø> (ø)
...nclude/xrpl/tx/transactors/account/AccountDelete.h 100.0% <100.0%> (ø)
include/xrpl/tx/transactors/account/AccountSet.h 100.0% <100.0%> (ø)
...nclude/xrpl/tx/transactors/account/SignerListSet.h 100.0% <100.0%> (ø)
include/xrpl/tx/transactors/check/CheckCancel.h 100.0% <100.0%> (ø)
include/xrpl/tx/transactors/check/CheckCash.h 100.0% <100.0%> (ø)
include/xrpl/tx/transactors/check/CheckCreate.h 100.0% <100.0%> (ø)
include/xrpl/tx/transactors/delegate/DelegateSet.h 100.0% <ø> (ø)
include/xrpl/tx/transactors/dex/OfferCancel.h 100.0% <100.0%> (ø)
... and 30 more

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread include/xrpl/tx/transactors/account/AccountSet.h Outdated
@mvadari mvadari added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 18, 2026
@bthomee
bthomee added this pull request to the merge queue Mar 18, 2026
Merged via the queue into XRPLF:develop with commit d360e7c Mar 18, 2026
3 checks passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants