Refactor: Update transaction folder structure - #6483
Merged
Conversation
- Rename subdirs to lowercase (AMM→amm, Check→check, NFT→nft, etc.) - Merge AMM and Offer into dex/, add PermissionedDEXHelpers - Rename mpt→token, add SetTrust and Clawback - Group: account, bridge, oracle, payment, system, escrow, did, credentials, payment_channel, permissioned_domain, vault, lending Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Tapanito
force-pushed
the
tapanito/tx-restructure
branch
from
March 5, 2026 13:50
4c6562a to
bd7d9ef
Compare
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6483 +/- ##
=========================================
- Coverage 79.9% 79.8% -0.0%
=========================================
Files 861 861
Lines 67858 67858
Branches 7553 7552 -1
=========================================
- Hits 54188 54175 -13
- Misses 13670 13683 +13
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
mvadari
approved these changes
Mar 5, 2026
Contributor
|
Looks cool. We need to get this merged soon before we see more and more conflicts. |
a1q123456
approved these changes
Mar 5, 2026
Contributor
|
@Tapanito ready to merge? |
Contributor
Author
|
@mvadari , Im fixing the conflicts, |
Tapanito
added
the
Ready to merge
bthomee
enabled auto-merge (squash)
March 5, 2026 16:52
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This change reorganizes the `tx/transactors` directory for consistency and discoverability. There are no behavioral changes, this is a pure refactor. Underscores were chosen as the way to separate multi-words as this is the more popular option in C++ projects. Specific changes: - Rename all subdirectories to lowercase/snake_case (`AMM` → `amm`, `Check` → `check`, `NFT` → `nft`, `PermissionedDomain` → `permissioned_domain`, etc.) - Merge `AMM/` and `Offer/` into `dex/`, including `PermissionedDEXHelpers` - Rename `MPT/` → `token/`, absorbing `SetTrust` and `Clawback` - Move top-level transactors into named groups: `account/`, `bridge/`, `credentials/`, `did/`, `escrow/`, `oracle/`, `payment/`, `payment_channel/`, `system/` - Update all include paths across the codebase and `transactions.macro`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganizes the
tx/transactorsdirectory for consistency and discoverability. No behavioral changes, this is a pure refactor. Underscores were chosen as the way to separate multi-words as this is the more popular option inC++projects.Changes
Reorganize transactors into feature subdirectories
AMM→amm,Check→check,NFT→nft,PermissionedDomain→permissioned_domain, etc.)AMM/andOffer/intodex/, includingPermissionedDEXHelpersMPT/→token/, absorbingSetTrustandClawbackaccount/,bridge/,credentials/,did/,escrow/,oracle/,payment/,payment_channel/,system/transactions.macroHigh Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)