Sponsored Content
Skip to content

test: Remove testline JTX helper class - #6539

Merged
bthomee merged 4 commits into
XRPLF:developfrom
mvadari:remove-testline
Mar 16, 2026
Merged

test: Remove testline JTX helper class#6539
bthomee merged 4 commits into
XRPLF:developfrom
mvadari:remove-testline

Conversation

@mvadari

@mvadari mvadari commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR removes the JTX helper class testline, which adds the line that made the env call.

Context of Change

testline.h is unnecessary after #6276

API Impact

N/A

Test Plan

CI passes, it builds properly.

@mvadari
mvadari requested a review from ximinez March 12, 2026 18:19
@mvadari mvadari changed the title refactor(tests): Remove testline refactor: Remove testline in tests Mar 12, 2026

@ximinez ximinez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward.

@mvadari
mvadari requested a review from Tapanito March 12, 2026 18:48
@codecov

codecov Bot commented Mar 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.8%. Comparing base (9838162) to head (57767b9).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6539     +/-   ##
=========================================
- Coverage     79.9%   79.8%   -0.0%     
=========================================
  Files          878     878             
  Lines        67888   67888             
  Branches      7548    7569     +21     
=========================================
- Hits         54209   54183     -26     
- Misses       13679   13705     +26     

see 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 16, 2026
@bthomee bthomee changed the title refactor: Remove testline in tests test: Remove testline JTX helper class Mar 16, 2026
@bthomee
bthomee enabled auto-merge (squash) March 16, 2026 15:44
@bthomee
bthomee merged commit e4dbaf5 into XRPLF:develop Mar 16, 2026
3 checks passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
This change removes the JTX helper class `testline`, which adds the line that made the `env` call, as it is no longer necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants