📚 Tutorial: feat(test): add file/line to Env by mvadari · Pull Request #6276 · XRPLF/rippled · GitHub

mvadari · 2026-01-23T21:02:48Z

High Level Overview of Change

This PR uses std::source_location to add to test Env error output the file and line location of the call that triggered the failed transaction.

There is no change to the source code.

Context of Change

Improved test logging, easier debugging

Type of Change

New feature (non-breaking change which adds functionality)

API Impact

N/A

Test Plan

I used this commit to help me debug a test failure in another branch.

Copilot

Pull request overview

This PR enhances test debugging by adding source location information (file and line number) to test environment error messages using C++20's std::source_location. When test transactions fail, the error output will now include the exact file and line where the test was invoked.

Changes:

Adds std::source_location parameters to submit(), sign_and_submit(), and postconditions() methods to capture call site location
Introduces WithSourceLoc wrapper struct to enable implicit conversion with source location capture for variadic template methods
Updates error messages to include file and line information in the format (filename:line)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/test/jtx/Env.h	Adds `WithSourceLoc` wrapper struct and updates method signatures to accept source location parameters
src/test/jtx/impl/Env.cpp	Implements source location threading through submission methods and formats location info in error messages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2026-01-23T21:36:06Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.9%. Comparing base (677758b) to head (f411ccd).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #6276   +/-   ##
=======================================
  Coverage     79.9%   79.9%           
=======================================
  Files          840     840           
  Lines        65483   65483           
  Branches      7255    7251    -4     
=======================================
+ Hits         52311   52319    +8     
+ Misses       13172   13164    -8

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-28T22:18:08Z

+    WithSourceLoc(Json::Value v, std::source_location l = std::source_location::current()) : value(std::move(v)), loc(l)
+    {
+    }
+
+    WithSourceLoc(JTx v, std::source_location l = std::source_location::current()) : value(std::move(v)), loc(l)
+    {
+    }


Both constructors can be implemented more concisely on a single line since the bodies are empty. Consider: WithSourceLoc(Json::Value v, std::source_location l = std::source_location::current()) : value(std::move(v)), loc(l) {}

Suggested change

WithSourceLoc(Json::Value v, std::source_location l = std::source_location::current()) : value(std::move(v)), loc(l)

{

}

WithSourceLoc(JTx v, std::source_location l = std::source_location::current()) : value(std::move(v)), loc(l)

{

}

WithSourceLoc(Json::Value v, std::source_location l = std::source_location::current()) : value(std::move(v)), loc(l) {}

WithSourceLoc(JTx v, std::source_location l = std::source_location::current()) : value(std::move(v)), loc(l) {}

Removed the need for this in a61c815

a1q123456

Some suggestions

a1q123456 · 2026-01-30T15:50:05Z

 namespace test {
 namespace jtx {

+class Env;  // Forward declaration


I don't think this is needed

Removed in a61c815

a1q123456 · 2026-01-30T15:53:12Z

+    Json::Value or JTx, allowing implicit conversion without template
+    argument deduction issues.
+*/
+struct WithSourceLoc


May be worth making it a template class so that you don't need to use std::variant and it's clearer.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

a1q123456

LGTM

a1q123456 · 2026-02-06T13:58:40Z

Oh I thought I didn't approve it. Sorry for the noise.

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

This change uses `std::source_location` to output the file and line location of the call that triggered a failed transaction.

Copilot AI review requested due to automatic review settings January 23, 2026 21:02

Copilot started reviewing on behalf of mvadari January 23, 2026 21:03 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

Comment thread src/test/jtx/Env.h Outdated

Comment thread src/test/jtx/impl/Env.cpp Outdated

Copilot AI review requested due to automatic review settings January 28, 2026 21:06

mvadari force-pushed the env-file-loc branch from 610c3ea to 0f93bd7 Compare January 28, 2026 21:06

Copilot started reviewing on behalf of mvadari January 28, 2026 21:06 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

Comment thread src/test/jtx/impl/Env.cpp Outdated

Comment thread src/test/jtx/impl/Env.cpp Outdated

Comment thread src/test/jtx/impl/Env.cpp Outdated

Comment thread src/test/jtx/impl/Env.cpp

Comment thread src/test/jtx/impl/Env.cpp

add file/line to Env

45b6c7c

mvadari force-pushed the env-file-loc branch from 0f93bd7 to 45b6c7c Compare January 28, 2026 21:33

mvadari added the Needs additional review PR requires at least one more code review approval before it can be merged label Jan 28, 2026

mvadari requested a review from Copilot January 28, 2026 22:16

Copilot started reviewing on behalf of mvadari January 28, 2026 22:16 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

bthomee requested a review from a1q123456 January 30, 2026 12:41

a1q123456 requested changes Jan 30, 2026

View reviewed changes

mvadari added 2 commits February 4, 2026 16:49

Merge remote-tracking branch 'upstream/develop' into env-file-loc

1630f63

Merge remote-tracking branch 'upstream/develop' into env-file-loc

f6b72bd

Copilot AI review requested due to automatic review settings February 5, 2026 18:33

Copilot started reviewing on behalf of mvadari February 5, 2026 18:34 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

Comment thread src/test/jtx/Env.h Outdated

respond to comments

a61c815

mvadari requested a review from a1q123456 February 5, 2026 19:24

WithSourceLoc -> WithSourceLocation

82041a6

Copilot AI review requested due to automatic review settings February 5, 2026 19:38

Copilot started reviewing on behalf of mvadari February 5, 2026 19:38 View session

clean up comments

6c1ba50

Copilot AI reviewed Feb 5, 2026

View reviewed changes

oops

212a346

a1q123456 approved these changes Feb 5, 2026

View reviewed changes

mvadari added Needs additional review PR requires at least one more code review approval before it can be merged and removed Needs additional review PR requires at least one more code review approval before it can be merged labels Feb 5, 2026

a1q123456 approved these changes Feb 6, 2026

View reviewed changes

Merge branch 'develop' into env-file-loc

cb42ee1

Copilot AI review requested due to automatic review settings February 6, 2026 14:49

bthomee approved these changes Feb 6, 2026

View reviewed changes

bthomee removed the Needs additional review PR requires at least one more code review approval before it can be merged label Feb 6, 2026

Copilot started reviewing on behalf of bthomee February 6, 2026 14:50 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

Comment thread src/test/jtx/impl/Env.cpp Outdated

Comment thread src/test/jtx/Env.h

Update src/test/jtx/impl/Env.cpp

76ee400

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 6, 2026 15:25

Copilot started reviewing on behalf of mvadari February 6, 2026 15:25 View session

mvadari added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Feb 6, 2026

Copilot AI reviewed Feb 6, 2026

View reviewed changes

mvadari and others added 2 commits February 6, 2026 11:02

Fix Env_ss

e9b252a

Merge branch 'develop' into env-file-loc

f411ccd

Copilot AI review requested due to automatic review settings February 6, 2026 16:52

Copilot started reviewing on behalf of bthomee February 6, 2026 16:53 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

bthomee enabled auto-merge (squash) February 6, 2026 17:25

bthomee merged commit f5208fc into XRPLF:develop Feb 6, 2026
3 checks passed

mvadari deleted the env-file-loc branch March 12, 2026 17:09

mvadari mentioned this pull request Mar 12, 2026

test: Remove testline JTX helper class #6539

Merged

mvadari added this to the 3.2.0 milestone May 20, 2026

beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026

test: Add file and line location to Env (XRPLF#6276)

26d0ef8

This change uses `std::source_location` to output the file and line location of the call that triggered a failed transaction.

Uh oh!

Conversation

mvadari commented Jan 23, 2026

High Level Overview of Change

Context of Change

Type of Change

API Impact

Test Plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

mvadari Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

a1q123456 left a comment

Choose a reason for hiding this comment

Uh oh!

a1q123456 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

mvadari Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

a1q123456 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

mvadari Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

a1q123456 left a comment

Choose a reason for hiding this comment

Uh oh!

a1q123456 commented Feb 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

codecov Bot commented Jan 23, 2026 •

edited

Loading