Sponsored Content
Skip to content

chore: cleaned up misleading comments - #6031

Merged
bthomee merged 2 commits into
developfrom
vvysokikh1/comment-cleanup1
Nov 13, 2025
Merged

chore: cleaned up misleading comments#6031
bthomee merged 2 commits into
developfrom
vvysokikh1/comment-cleanup1

Conversation

@vvysokikh1

Copy link
Copy Markdown
Contributor

High Level Overview of Change

cleaned up misleading comments left in tests after one of amendment retirements

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@vvysokikh1 vvysokikh1 added Documentation README changes, code comments, etc. Trivial Simple change with minimal effect, or already tested. Only needs one approval. labels Nov 13, 2025
@codecov

codecov Bot commented Nov 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.6%. Comparing base (508937f) to head (2f6d79c).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6031   +/-   ##
=======================================
  Coverage     78.6%   78.6%           
=======================================
  Files          817     817           
  Lines        68985   68985           
  Branches      8239    8235    -4     
=======================================
+ Hits         54204   54212    +8     
+ Misses       14781   14773    -8     

see 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tapanito

Copy link
Copy Markdown
Contributor

@vvysokikh1 just to be a little pedantic, how do we know that the comments are missleading?

I.e. I assume you're removing them because that's not what the system does, but how do we know that that's not what the system is supposed to do?

@pratikmankawde pratikmankawde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for removing them.

@vvysokikh1

Copy link
Copy Markdown
Contributor Author

@vvysokikh1 just to be a little pedantic, how do we know that the comments are missleading?

I.e. I assume you're removing them because that's not what the system does, but how do we know that that's not what the system is supposed to do?

this test was modified in the previous amendment retirement PR #5946.

These comments describe the pre-amendment behavior and since we retired that they no longer hold any meaning

@bthomee
bthomee enabled auto-merge (squash) November 13, 2025 13:18
@bthomee
bthomee merged commit f81d0d8 into develop Nov 13, 2025
1 check passed
@bthomee
bthomee deleted the vvysokikh1/comment-cleanup1 branch November 13, 2025 13:37
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
This change cleans up incorrect comments that were left in test cases after one of the amendments was retired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation README changes, code comments, etc. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants