chore: cleaned up misleading comments - #6031
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6031 +/- ##
=======================================
Coverage 78.6% 78.6%
=======================================
Files 817 817
Lines 68985 68985
Branches 8239 8235 -4
=======================================
+ Hits 54204 54212 +8
+ Misses 14781 14773 -8 🚀 New features to boost your workflow:
|
|
@vvysokikh1 just to be a little pedantic, how do we know that the comments are missleading? I.e. I assume you're removing them because that's not what the system does, but how do we know that that's not what the system is supposed to do? |
pratikmankawde
left a comment
There was a problem hiding this comment.
LGTM. Thanks for removing them.
this test was modified in the previous amendment retirement PR #5946. These comments describe the pre-amendment behavior and since we retired that they no longer hold any meaning |
This change cleans up incorrect comments that were left in test cases after one of the amendments was retired.
High Level Overview of Change
cleaned up misleading comments left in tests after one of amendment retirements
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)