Sponsored Content
Skip to content

Retire PayChanRecipientOwnerDir amendment - #5946

Merged
bthomee merged 10 commits into
developfrom
pratik/Retire-fixPaychanRecipientOwnerDir-amendment
Nov 11, 2025
Merged

Retire PayChanRecipientOwnerDir amendment#5946
bthomee merged 10 commits into
developfrom
pratik/Retire-fixPaychanRecipientOwnerDir-amendment

Conversation

@pratikmankawde

@pratikmankawde pratikmankawde commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This change retires the fix_paychan_recipient_owner_dir amendment.

Context of Change

Amendments activated for more than 2 years can be retired.
https://xrpl.org/resources/known-amendments#fixpaychanrecipientownerdir

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
@pratikmankawde pratikmankawde changed the title Pratik/retire fix paychan recipient owner dir amendment Retire fix_paychan_recipient_owner_dir amendment Oct 28, 2025
@pratikmankawde
pratikmankawde marked this pull request as ready for review October 28, 2025 14:13
@pratikmankawde
pratikmankawde requested a review from a team October 28, 2025 14:13
@codecov

codecov Bot commented Oct 28, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.6%. Comparing base (3330948) to head (749fe51).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5946     +/-   ##
=========================================
- Coverage     78.6%   78.6%   -0.0%     
=========================================
  Files          817     817             
  Lines        69023   69021      -2     
  Branches      8264    8241     -23     
=========================================
- Hits         54257   54246     -11     
- Misses       14766   14775      +9     
Files with missing lines Coverage Δ
src/xrpld/app/tx/detail/PayChan.cpp 95.5% <100.0%> (-0.8%) ⬇️

... and 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…-amendment

Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
…-amendment

Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
…-amendment

Signed-off-by: Pratik Mankawde <pmankawde@ripple.com>
@bthomee bthomee changed the title Retire fix_paychan_recipient_owner_dir amendment Retire PayChanRecipientOwnerDir amendment Nov 11, 2025
Comment thread src/test/app/PayChan_test.cpp
@pratikmankawde pratikmankawde added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Nov 11, 2025
@bthomee
bthomee merged commit 9b332d8 into develop Nov 11, 2025
3 checks passed
@bthomee
bthomee deleted the pratik/Retire-fixPaychanRecipientOwnerDir-amendment branch November 11, 2025 14:07
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Amendments activated for more than 2 years can be retired. This change retires the PayChanRecipientOwnerDir amendment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants