Sponsored Content
Skip to content

runtime-linux.md: terms "source" and "destination" are very unclear for symlinks #1165

Open

Description

@safinaskar

I'm reading https://github.com/opencontainers/runtime-spec/blob/main/runtime-linux.md . When I first time saw this table with columns "source" and "destination", I thought that there is an error, i. e. columns are swapped. Then I understand that there is no error here. Still I think that terms "source" and "destination" are very confusing, so, please, use some alternate terms, for example "link" and "pointee", "pointer" and "pointee", "link" and "object", etc. I prefer "link" and "object"

Activity

  1. tianon commented on Oct 31, 2022

    @tianon
    Member

    Maybe we should go with target and linkpath so that we unambiguously match the Linux symlink(2) and symlinkat(2) terms?

    https://man7.org/linux/man-pages/man2/symlinkat.2.html

  2. safinaskar commented on Nov 2, 2022

    @safinaskar
    Author

    @tianon , target and linkpath are very ambiguous

  3. tianon commented on Nov 2, 2022

    @tianon
    Member
  4. safinaskar commented on Nov 2, 2022

    @safinaskar
    Author

    @tianon , I still think that we should just use some unambiguous clear words instead of using "official" ones and inviting a user to follow some documentation. That manual page ( https://man7.org/linux/man-pages/man2/symlinkat.2.html ) is bad, too, and similarly should be fixed.

    Also, please note that terms "target" and "linkpath" are not "official" in any way. This is just terms used by author of that manual page. My local copy of unistd.h file uses terms __from and __to. Linux kernel source uses terms oldname and newname: https://elixir.bootlin.com/linux/v6.1-rc3/source/fs/namei.c#L4449 . POSIX uses terms path1 and path2: https://pubs.opengroup.org/onlinepubs/9699919799/functions/symlink.html . So, there is no any "official" terms. I propose using terms, which people (hopefully) will understand: "object" and "link"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions