Sponsored Content
Skip to content

chore: Pin Python packages for codegen using uv - #7329

Merged
bthomee merged 1 commit into
XRPLF:developfrom
mathbunnyru:pin_codegen_vers
May 26, 2026
Merged

chore: Pin Python packages for codegen using uv#7329
bthomee merged 1 commit into
XRPLF:developfrom
mathbunnyru:pin_codegen_vers

Conversation

@mathbunnyru

@mathbunnyru mathbunnyru commented May 26, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR pins package versions so that the depth-first bot does not get confused.
A bit better implementation of #7291.
Closes: #7291

uv is getting more and more popular, while hashin is not so popular and is restricted for 1 task only.

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

# Template engine - used to generate C++ code from templates
Mako>=1.2.2
# This file was autogenerated by uv via the following command:
# uv pip compile requirements.in --generate-hashes --output-file requirements.txt

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has been completely autogenerated using this command - this is better than mixing auto-generated and manually written files.

@bthomee
bthomee requested a review from Copilot May 26, 2026 17:58
@mathbunnyru mathbunnyru added Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval. labels May 26, 2026
@bthomee
bthomee enabled auto-merge May 26, 2026 17:59
@mathbunnyru mathbunnyru mentioned this pull request May 26, 2026
4 tasks

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the Python dependencies used by the protocol code generation tooling (invoked via CMake setup_code_gen) to make installs deterministic and avoid dependency-resolution drift.

Changes:

  • Introduces a requirements.in source file with unpinned/min-version constraints for codegen dependencies.
  • Replaces the prior loose requirements.txt with a uv pip compile --generate-hashes output that pins exact versions and includes hashes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
cmake/scripts/codegen/requirements.txt Switches to a uv-compiled, fully pinned (+ hashed) requirements file for deterministic installs.
cmake/scripts/codegen/requirements.in Adds the human-edited input file used to generate the pinned requirements.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cmake/scripts/codegen/requirements.txt
Comment thread cmake/scripts/codegen/requirements.in
@codecov

codecov Bot commented May 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.4%. Comparing base (49cb3f4) to head (c34c47c).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #7329   +/-   ##
=======================================
  Coverage     82.4%   82.4%           
=======================================
  Files         1011    1011           
  Lines        76338   76382   +44     
  Branches      7311    7310    -1     
=======================================
+ Hits         62868   62912   +44     
  Misses       13470   13470           

see 6 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee
bthomee added this pull request to the merge queue May 26, 2026
Merged via the queue into XRPLF:develop with commit ac33fb3 May 26, 2026
3 checks passed
@bthomee bthomee added this to the 3.2.0 milestone May 27, 2026
Kassaking7 pushed a commit to Kassaking7/rippled that referenced this pull request Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants