chore: Pin Python packages for codegen using uv - #7329
Conversation
| # Template engine - used to generate C++ code from templates | ||
| Mako>=1.2.2 | ||
| # This file was autogenerated by uv via the following command: | ||
| # uv pip compile requirements.in --generate-hashes --output-file requirements.txt |
There was a problem hiding this comment.
This file has been completely autogenerated using this command - this is better than mixing auto-generated and manually written files.
There was a problem hiding this comment.
Pull request overview
Pins the Python dependencies used by the protocol code generation tooling (invoked via CMake setup_code_gen) to make installs deterministic and avoid dependency-resolution drift.
Changes:
- Introduces a
requirements.insource file with unpinned/min-version constraints for codegen dependencies. - Replaces the prior loose
requirements.txtwith auv pip compile --generate-hashesoutput that pins exact versions and includes hashes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmake/scripts/codegen/requirements.txt | Switches to a uv-compiled, fully pinned (+ hashed) requirements file for deterministic installs. |
| cmake/scripts/codegen/requirements.in | Adds the human-edited input file used to generate the pinned requirements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7329 +/- ##
=======================================
Coverage 82.4% 82.4%
=======================================
Files 1011 1011
Lines 76338 76382 +44
Branches 7311 7310 -1
=======================================
+ Hits 62868 62912 +44
Misses 13470 13470 🚀 New features to boost your workflow:
|
High Level Overview of Change
This PR pins package versions so that the depth-first bot does not get confused.
A bit better implementation of #7291.
Closes: #7291
uvis getting more and more popular, whilehashinis not so popular and is restricted for 1 task only.Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)