style: Use shfmt instead of bashate - #7326
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7326 +/- ##
=========================================
- Coverage 82.4% 82.4% -0.0%
=========================================
Files 1011 1011
Lines 76382 76382
Branches 7315 7315
=========================================
- Hits 62914 62902 -12
- Misses 13468 13480 +12 🚀 New features to boost your workflow:
|
bthomee
approved these changes
May 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s formatting/linting tooling by switching shell-script checks from bashate to shfmt, and applies automated formatting changes across various shell scripts to match the new formatter’s output.
Changes:
- Replace
bashatepre-commit hook withshfmt(and addshfmtto cspell dictionary). - Reformat multiple shell scripts to
shfmtstyle (indentation, spacing, redirections, etc.). - Also bump several other pre-commit tool revisions (clang-format, gersemi, prettier, black, cspell).
Reviewed changes
Copilot reviewed 3 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
package/shared/update-xrpld |
Minor formatting adjustments consistent with shfmt. |
package/build_pkg.sh |
Reformats CLI parsing and staging logic to shfmt style. |
cspell.config.yaml |
Adds shfmt to allowed words. |
bin/git/update-version.sh |
Reformats script; still contains some unquoted-variable robustness issues. |
bin/git/squash-branches.sh |
Reformats script; still contains some unquoted-variable/echo robustness issues. |
bin/git/setup-upstreams.sh |
Reformats script (minor whitespace/redirect changes). |
.pre-commit-config.yaml |
Switches from bashate to shfmt and updates multiple other tool pins. |
.github/scripts/rename/namespace.sh |
Minor redirect formatting (&>/dev/null). |
.github/scripts/rename/docs.sh |
Minor redirect formatting (&>/dev/null). |
.github/scripts/rename/definitions.sh |
Minor redirect formatting (&>/dev/null). |
.github/scripts/rename/copyright.sh |
Minor formatting; still uses unsafe echo -e prepend pattern that can corrupt files. |
.github/scripts/rename/config.sh |
Minor redirect formatting (&>/dev/null). |
.github/scripts/rename/cmake.sh |
Minor redirect formatting and whitespace adjustments. |
.github/scripts/rename/binary.sh |
Minor redirect formatting (&>/dev/null). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
May 26, 2026
bthomee
enabled auto-merge
May 26, 2026 18:07
Kassaking7
pushed a commit
to Kassaking7/rippled
that referenced
this pull request
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
https://github.com/openstack/bashate was last released on Oct 6, 2022
And what's most important, it's not auto-formatting, and the code ends up somewhat similar, but still not uniform.
https://github.com/mvdan/sh#shfmt is a much more modern alternative.
Let's use it.
Note: the second commit is a fully automatic change.
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)