fix: Fix RPM prerelease ordering and start xrpld on DEB install - #7313
Merged
Conversation
legleux
marked this pull request as ready for review
May 22, 2026 02:44
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7313 +/- ##
=========================================
- Coverage 82.4% 82.3% -0.0%
=========================================
Files 1011 1011
Lines 76248 76248
Branches 7313 7311 -2
=========================================
- Hits 62793 62777 -16
- Misses 13455 13471 +16 🚀 New features to boost your workflow:
|
bthomee
approved these changes
May 22, 2026
mathbunnyru
approved these changes
May 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts packaging behaviors so pre-release RPM builds sort/upgrade correctly and Debian installs start xrpld by default without forcing a stop during upgrades.
Changes:
- Fix RPM
Releaseconstruction for pre-releases to preserve expectedrpmvercmpordering across beta builds (e.g.,b5 -> b6). - Update Debian
dh_installsystemdinvocation soxrpld.servicestarts on fresh install while avoiding stop-on-upgrade behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
package/debian/rules |
Switches dh_installsystemd options so xrpld.service is started on fresh installs but not stopped during upgrades. |
package/build_pkg.sh |
Changes RPM pre-release Release formatting to 0.<pkg_release>.<suffix> to maintain correct prerelease ordering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bthomee
enabled auto-merge
May 22, 2026 11:30
Kassaking7
pushed a commit
to Kassaking7/rippled
that referenced
this pull request
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
b6upgrades fromb5.xrpld.serviceon fresh DEB installs while avoiding an immediate restart during DEB upgrades.Details
The RPM packaging version logic now preserves the expected prerelease ordering for beta builds. This prevents package managers from treating an older beta build as newer or refusing the expected
b5→b6upgrade path.For DEB packaging,
xrpld.servicenow usesdh_installsystemd --no-stop-on-upgrade. This starts the service after a fresh install, but avoids stopping/restarting an already-running daemon during package upgrades.The
update-xrpldtimer remains configured with--no-start.Testing
xrpld.service.xrpld.service.update-xrpld.timeris not started.