Sponsored Content
Skip to content

fix: Fix RPM prerelease ordering and start xrpld on DEB install - #7313

Merged
bthomee merged 1 commit into
developfrom
legleux/fix-rpm-version
May 22, 2026
Merged

fix: Fix RPM prerelease ordering and start xrpld on DEB install#7313
bthomee merged 1 commit into
developfrom
legleux/fix-rpm-version

Conversation

@legleux

@legleux legleux commented May 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  1. Fix RPM prerelease version ordering so newer beta builds sort correctly, e.g. b6 upgrades from b5.
  2. Start xrpld.service on fresh DEB installs while avoiding an immediate restart during DEB upgrades.

Details

  1. The RPM packaging version logic now preserves the expected prerelease ordering for beta builds. This prevents package managers from treating an older beta build as newer or refusing the expected b5b6 upgrade path.

  2. For DEB packaging, xrpld.service now uses dh_installsystemd --no-stop-on-upgrade. This starts the service after a fresh install, but avoids stopping/restarting an already-running daemon during package upgrades.

The update-xrpld timer remains configured with --no-start.

Testing

  • Verified RPM package ordering for the affected beta versions.
  • Verified fresh DEB install starts xrpld.service.
  • Verified DEB upgrade does not immediately restart xrpld.service.
  • Verified update-xrpld.timer is not started.

@legleux legleux changed the title fix: rpm version and start deb on install fix: RPM prerelease ordering and start xrpld on DEB install May 21, 2026
@legleux
legleux marked this pull request as ready for review May 22, 2026 02:44
@legleux
legleux requested review from bthomee and mathbunnyru May 22, 2026 02:46

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Opus 4.6 · Prompt: V15

@codecov

codecov Bot commented May 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.3%. Comparing base (3547a93) to head (2f092d6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #7313     +/-   ##
=========================================
- Coverage     82.4%   82.3%   -0.0%     
=========================================
  Files         1011    1011             
  Lines        76248   76248             
  Branches      7313    7311      -2     
=========================================
- Hits         62793   62777     -16     
- Misses       13455   13471     +16     

see 8 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts packaging behaviors so pre-release RPM builds sort/upgrade correctly and Debian installs start xrpld by default without forcing a stop during upgrades.

Changes:

  • Fix RPM Release construction for pre-releases to preserve expected rpmvercmp ordering across beta builds (e.g., b5 -> b6).
  • Update Debian dh_installsystemd invocation so xrpld.service starts on fresh install while avoiding stop-on-upgrade behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
package/debian/rules Switches dh_installsystemd options so xrpld.service is started on fresh installs but not stopped during upgrades.
package/build_pkg.sh Changes RPM pre-release Release formatting to 0.<pkg_release>.<suffix> to maintain correct prerelease ordering.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mathbunnyru mathbunnyru added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label May 22, 2026
@bthomee bthomee changed the title fix: RPM prerelease ordering and start xrpld on DEB install fix: Fix RPM prerelease ordering and start xrpld on DEB install May 22, 2026
@bthomee
bthomee enabled auto-merge May 22, 2026 11:30
@bthomee
bthomee added this pull request to the merge queue May 22, 2026
Merged via the queue into develop with commit 15dd653 May 22, 2026
3 checks passed
@bthomee
bthomee deleted the legleux/fix-rpm-version branch May 22, 2026 12:18
@bthomee bthomee added this to the 3.2.0 milestone May 27, 2026
Kassaking7 pushed a commit to Kassaking7/rippled that referenced this pull request Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants