refactor: Remove dead fetchBatch code - #7309
Merged
Merged
Conversation
![xrplf-ai-reviewer[bot]](https://avatars.githubusercontent.com/u/67929741?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the unused fetchBatch NodeStore API and its backend implementations, simplifying the NodeStore backend interface and reducing dead code paths.
Changes:
- Removed
DatabaseNodeImp::fetchBatchimplementation and declaration. - Removed
Backend::fetchBatchpure-virtual API from the public NodeStore backend interface. - Deleted
fetchBatchoverrides from RocksDB, NuDB, Memory, and Null backend implementations.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/libxrpl/nodestore/DatabaseNodeImp.cpp | Removes the unused DatabaseNodeImp::fetchBatch implementation. |
| src/libxrpl/nodestore/backend/RocksDBFactory.cpp | Removes RocksDBBackend::fetchBatch override. |
| src/libxrpl/nodestore/backend/NullFactory.cpp | Removes NullBackend::fetchBatch override. |
| src/libxrpl/nodestore/backend/NuDBFactory.cpp | Removes NuDBBackend::fetchBatch override. |
| src/libxrpl/nodestore/backend/MemoryFactory.cpp | Removes MemoryBackend::fetchBatch override. |
| include/xrpl/nodestore/detail/DatabaseNodeImp.h | Removes the fetchBatch declaration from the installed DatabaseNodeImp header. |
| include/xrpl/nodestore/Backend.h | Removes the public pure-virtual fetchBatch method from the installed backend interface. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bthomee
added
the
Trivial
bthomee
enabled auto-merge
May 21, 2026 17:16
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7309 +/- ##
=========================================
+ Coverage 82.1% 82.3% +0.2%
=========================================
Files 1011 1011
Lines 76387 76190 -197
Branches 7411 7309 -102
=========================================
- Hits 62732 62725 -7
+ Misses 13655 13465 -190
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
bthomee
added
the
Ready to merge
shortthefomo
added a commit
to shortthefomo/rippled
that referenced
this pull request
May 22, 2026
Kassaking7
pushed a commit
to Kassaking7/rippled
that referenced
this pull request
Jun 2, 2026
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This change removes the
fetchBatchfunctionality, as it was unused.Context of Change
The
fetchBatchfunctionality was introduced in 1b49776, but the code was actually never used.