You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Added the --parallel N flag to the cmake --build commands in BUILD.md to document how to speed up builds using parallel jobs.
Context of Change
The build documentation didn't mention the --parallel flag, which is a common way to significantly reduce build times. This is a documentation-only change with no code impact.
API Impact
No impact. Only a documentation change.
Public API: New feature (new methods and/or new fields)
Public API: Breaking change (in general, breaking changes should only impact the next api_version)
libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
Peer protocol change (must be backward compatible or bump the peer protocol version)
⚠️ This PR contains unsigned commits. To get your PR merged, please sign them. ⚠️
If only the most recent commit is unsigned, you can run:
Amend the commit: git commit --amend --no-edit -n -S
Overwrite the commit: git push --force-with-lease
If multiple commits are unsigned, you can run:
Go into interactive rebase mode: git rebase --interactive HEAD~<NUM_OF_COMMITS>, where NUM_OF_COMMITS is the number of most recent commits that will be available to edit.
Change "pick" to "edit" for the commits you need to sign, and then save and exit.
For each commit, run: git commit --amend --no-edit -n -S
Continue the rebase: git rebase --continue
Overwrite the commit(s): git push --force-with-lease
If you're new to commit signing, there are different ways to set it up:
Sign commits with gpg
Follow the steps below to set up commit signing with gpg:
You can also sign commits using 1Password, which lets you sign commits with biometrics without the signing key leaving the local 1Password process.
See use 1Password to sign your commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrivialSimple change with minimal effect, or already tested. Only needs one approval.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Wait! Don't Go Yet 🚀
Get our FREE eBook "10 Programming Tips That Changed Everything" when you subscribe to our newsletter!
High Level Overview of Change
Added the
--parallel Nflag to thecmake --buildcommands in BUILD.md to document how to speed up builds using parallel jobs.Context of Change
The build documentation didn't mention the
--parallelflag, which is a common way to significantly reduce build times. This is a documentation-only change with no code impact.API Impact
No impact. Only a documentation change.
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)