refactor: Prevent dry-run transactions from being queued (#92) - #7131
Merged
Conversation
## High Level Overview of Change Transactions marked for simulation-only processing were not being filtered at queue entry point. ### API Impact <!-- Please check [x] relevant options, delete irrelevant ones. * If there is any impact to the public API methods (HTTP / WebSocket), please update https://github.com/xrplf/rippled/blob/develop/API-CHANGELOG.md * Update API-CHANGELOG.md and add the change directly in this PR by pushing to your PR branch. * libxrpl: See https://github.com/XRPLF/rippled/blob/develop/docs/build/depend.md * Peer Protocol: See https://xrpl.org/peer-protocol.html --> - [ ] Public API: New feature (new methods and/or new fields) - [ ] Public API: Breaking change (in general, breaking changes should only impact the next api_version) - [ ] `libxrpl` change (any change that may affect `libxrpl` or dependents of `libxrpl`) - [ ] Peer protocol change (must be backward compatible or bump the peer protocol version) <!-- ## Before / After If relevant, use this section for an English description of the change at a technical level. If this change affects an API, examples should be included here. For performance-impacting changes, please provide these details: 1. Is this a new feature, bug fix, or improvement to existing functionality? 2. What behavior/functionality does the change impact? 3. In what processing can the impact be measured? Be as specific as possible - e.g. RPC client call, payment transaction that involves LOB, AMM, caching, DB operations, etc. 4. Does this change affect concurrent processing - e.g. does it involve acquiring locks, multi-threaded processing, or async processing? --> <!-- ## Test Plan If helpful, please describe the tests that you ran to verify your changes and provide instructions so that others can reproduce. This section may not be needed if your change includes thoroughly commented unit tests. --> <!-- ## Future Tasks For future tasks related to PR. -->
![xrplf-ai-reviewer[bot]](https://avatars.githubusercontent.com/u/67929741?s=60&v=4){kind=small}
mvadari
approved these changes
May 12, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7131 +/- ##
=======================================
Coverage 82.1% 82.1%
=======================================
Files 1010 1010
Lines 76145 76147 +2
Branches 7376 7376
=======================================
+ Hits 62548 62550 +2
Misses 13597 13597
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Collaborator
|
@vlntb is this ready to merge? |
vlntb
added
the
Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Transactions marked for simulation-only processing were not being filtered at queue entry point.
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)