fix: Check if the MPT first loss cover can be sent to the broker before deleting the broker

[a1q123456]

High Level Overview of Change

This PR adds some checks in LoanBrokerDelete::preclaim to ensure we can send the MPT to the broker account when we delete it.

Context of Change

It's currently possible to bypass MPT locks. preclaim() only validates the destination owner's freeze state, never the source pseudo-account. doApply() then transfers sfCoverAvailable via accountSend(), and the low-level MPT send path does not revalidate locks.

API Impact

• Public API: New feature (new methods and/or new fields)
• Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• Peer protocol change (must be backward compatible or bump the peer protocol version)

[xrplf-ai-reviewer]

Went over the changes

One likely copy-paste bug flagged inline: the deep-freeze check targets brokerOwner (already checked earlier) instead of brokerPseudo, making the new check a no-op.

---

Review by ReviewBot 🤖

Review by Claude Opus 4.6 · Prompt: V15

[xrplf-ai-reviewer]

Misleading copy-pasted comments flagged inline — assertions are correct but comments need updating.

Review by Claude Opus 4.6 · Prompt: V15

[a1q123456]

Making it a draft for a couple of hours to investigate a potential bug.

[xrplf-ai-reviewer]

No issues.

Review by Claude Opus 4.6 · Prompt: V15

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.1%. Comparing base (93836f2) to head (67726f4).
⚠️ Report is 21 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #7125     +/-   ##
=========================================
- Coverage     82.1%   82.1%   -0.0%     
=========================================
  Files         1010    1010             
  Lines        76151   76170     +19     
  Branches      7424    7410     -14     
=========================================
+ Hits         62497   62512     +15     
- Misses       13654   13658      +4     

Files with missing lines	Coverage Δ
...ibxrpl/tx/transactors/lending/LoanBrokerDelete.cpp	89.9% <100.0%> (+0.8%)	⬆️

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[xrplf-ai-reviewer]

No issues.

Review by Claude Opus 4.6 · Prompt: V15

[Copilot]

Pull request overview

This PR tightens LoanBrokerDelete validation to prevent bypassing MPToken lock/freeze restrictions when returning broker cover during deletion. It ensures the broker pseudo-account is eligible to send the cover back to the broker owner before deletion proceeds (amendment-gated), and adds regression tests covering both MPToken lock and IOU freeze scenarios.

Changes:

• Add an amendment-gated preclaim() check to validate the broker pseudo-account is not frozen/locked for the vault asset when cover would be transferred.
• Add a regression test ensuring locked MPToken cover cannot be returned to the owner via broker deletion when the fix is enabled.
• Add a regression test ensuring a frozen IOU trustline on the broker pseudo-account blocks broker deletion early (with the fix) vs invariant failure (without).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/test/app/LoanBroker_test.cpp	Adds regression tests for LoanBrokerDelete behavior when the broker pseudo-account’s holding is locked (MPT) or frozen (IOU), with/without fixCleanup3_2_0.
src/libxrpl/tx/transactors/lending/LoanBrokerDelete.cpp	Adds fixCleanup3_2_0-gated preclaim() call to checkFrozen() on the broker pseudo-account when cover would be returned.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[xrplf-ai-reviewer]

No issues.

Review by Claude Opus 4.6 · Prompt: V15

[Tapanito]

LGTM.

[xrplf-ai-reviewer]

Gave this a review

One misleading log message flagged inline — the text says "deep-frozen" but the check is checkFrozen on the pseudo-account, not the owner.

---

Review by ReviewBot 🤖

Review by Claude Opus 4.6 · Prompt: V15

[xrplf-ai-reviewer]

No issues.

Review by Claude Opus 4.6 · Prompt: V15

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.