Sponsored Content
Skip to content

ci: Make Show test failure summary work with no build dir - #7124

Merged
bthomee merged 4 commits into
XRPLF:developfrom
mathbunnyru:windows_failure
May 12, 2026
Merged

ci: Make Show test failure summary work with no build dir#7124
bthomee merged 4 commits into
XRPLF:developfrom
mathbunnyru:windows_failure

Conversation

@mathbunnyru

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Working directory is incorrect on Windows, let's try to fix it.
Example: https://github.com/XRPLF/rippled/actions/runs/25677777394/job/75381526818?pr=7109

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mathbunnyru mathbunnyru added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label May 12, 2026
@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.1%. Comparing base (c4c95db) to head (9674b80).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #7124     +/-   ##
=========================================
- Coverage     82.1%   82.1%   -0.0%     
=========================================
  Files         1010    1010             
  Lines        76064   76064             
  Branches      7380    7375      -5     
=========================================
- Hits         62471   62470      -1     
- Misses       13593   13594      +1     

see 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mathbunnyru mathbunnyru changed the title ci: Fix Windows working-directory on failure ci: Make Show test failure summary work with no build dir May 12, 2026
@mathbunnyru
mathbunnyru requested a review from bthomee May 12, 2026 15:48
@bthomee
bthomee added this pull request to the merge queue May 12, 2026
@bthomee bthomee added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label May 12, 2026
Merged via the queue into XRPLF:develop with commit aa55392 May 12, 2026
3 checks passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants