Sponsored Content
Skip to content

docs: Fix some comments to improve readability - #7122

Merged
bthomee merged 2 commits into
XRPLF:developfrom
box4wangjing:develop
May 20, 2026
Merged

docs: Fix some comments to improve readability#7122
bthomee merged 2 commits into
XRPLF:developfrom
box4wangjing:develop

Conversation

@box4wangjing

@box4wangjing box4wangjing commented May 12, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

fix some comments to improve readability

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Comment thread src/test/app/NFTokenBurn_test.cpp Outdated
Comment thread src/test/app/NFTokenBurn_test.cpp Outdated
@mvadari mvadari added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label May 12, 2026
@box4wangjing box4wangjing changed the title chore: remove extra word in comment chore: fix some comments to improve readability May 12, 2026
@box4wangjing

Copy link
Copy Markdown
Contributor Author

@mvadari Thanks. Please review it again.

@mvadari mvadari left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go once CI passes

@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.1%. Comparing base (93ac1aa) to head (3f00fed).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #7122     +/-   ##
=========================================
- Coverage     82.1%   82.1%   -0.0%     
=========================================
  Files         1010    1010             
  Lines        76167   76167             
  Branches      7423    7412     -11     
=========================================
- Hits         62514   62507      -7     
- Misses       13653   13660      +7     
Files with missing lines Coverage Δ
include/xrpl/json/Writer.h 93.3% <ø> (ø)
include/xrpl/protocol/detail/ledger_entries.macro 100.0% <ø> (ø)
src/libxrpl/protocol/STAmount.cpp 88.7% <ø> (ø)

... and 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari

mvadari commented May 18, 2026

Copy link
Copy Markdown
Contributor

@box4wangjing please update your branch and address the CI failures

Signed-off-by: box4wangjing <box4wangjing@outlook.com>
@box4wangjing box4wangjing changed the title chore: fix some comments to improve readability chore: Fix some comments to improve readability May 20, 2026
@box4wangjing

Copy link
Copy Markdown
Contributor Author

@box4wangjing please update your branch and address the CI failures

Thanks for your help.
Modified. @mvadari

@mvadari mvadari added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label May 20, 2026
@bthomee bthomee changed the title chore: Fix some comments to improve readability docs: Fix some comments to improve readability May 20, 2026
@bthomee
bthomee enabled auto-merge May 20, 2026 19:46
@bthomee
bthomee added this pull request to the merge queue May 20, 2026
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
Merged via the queue into XRPLF:develop with commit a5d238e May 20, 2026
3 checks passed
Kassaking7 pushed a commit to Kassaking7/rippled that referenced this pull request Jun 2, 2026
Signed-off-by: box4wangjing <box4wangjing@outlook.com>
Co-authored-by: Mayukha Vadari <mvadari@ripple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants