refactor: Limit JSON array size - #7112
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7112 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.0%
=========================================
Files 1010 1010
Lines 76070 76084 +14
Branches 7381 7380 -1
=========================================
- Hits 62457 62449 -8
- Misses 13613 13635 +22
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
mathbunnyru
approved these changes
May 12, 2026
vlntb
reviewed
May 12, 2026
| { | ||
| return RPC::makeError( | ||
| RpcInvalidParams, | ||
| "Field '" + makeName(object, field) + "' exceeds allowed JSON array size of " + |
Contributor
There was a problem hiding this comment.
[nit] Maybe include the actual size in the error details to help with troubleshooting.
vlntb
approved these changes
May 12, 2026
vlntb
left a comment
vlntb
left a comment
Contributor
There was a problem hiding this comment.
Minor nit. Otherwise LGTM.
mvadari
approved these changes
May 12, 2026
Collaborator
|
@godexsoft is this ready to merge? |
godexsoft
added
the
Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR refactors the JSON parsing and adds a check for array size.
API Impact
No impact.