Sponsored Content
Skip to content

fix: Improve json parsing of currency issuers - #7110

Merged
bthomee merged 2 commits into
XRPLF:developfrom
kuznetsss:Improve_json_parsing
May 12, 2026
Merged

fix: Improve json parsing of currency issuers#7110
bthomee merged 2 commits into
XRPLF:developfrom
kuznetsss:Improve_json_parsing

Conversation

@kuznetsss

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR adds an early detection of invalid currency issuer.

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens Issue JSON parsing by rejecting reserved/sentinel issuer accounts early, improving detection of invalid non-XRP issuer specifications.

Changes:

  • Extend issueFromJson issuer validation to reject noAccount() and xrpAccount() for non-XRP currencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/libxrpl/protocol/Issue.cpp
@codecov

codecov Bot commented May 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.1%. Comparing base (c4c95db) to head (b9e4490).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #7110     +/-   ##
=========================================
- Coverage     82.1%   82.1%   -0.0%     
=========================================
  Files         1010    1010             
  Lines        76064   76064             
  Branches      7380    7380             
=========================================
- Hits         62471   62459     -12     
- Misses       13593   13605     +12     
Files with missing lines Coverage Δ
src/libxrpl/protocol/Issue.cpp 92.7% <100.0%> (ø)

... and 6 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kuznetsss kuznetsss added this to the 3.1.3 (develop) milestone May 12, 2026
Comment thread src/libxrpl/protocol/Issue.cpp
@kuznetsss kuznetsss added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label May 12, 2026
@bthomee
bthomee added this pull request to the merge queue May 12, 2026
Merged via the queue into XRPLF:develop with commit 448ae8b May 12, 2026
3 checks passed
@kuznetsss
kuznetsss deleted the Improve_json_parsing branch May 13, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants