fix: Improve json parsing of currency issuers - #7110
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens Issue JSON parsing by rejecting reserved/sentinel issuer accounts early, improving detection of invalid non-XRP issuer specifications.
Changes:
- Extend
issueFromJsonissuer validation to rejectnoAccount()andxrpAccount()for non-XRP currencies.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7110 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.0%
=========================================
Files 1010 1010
Lines 76064 76064
Branches 7380 7380
=========================================
- Hits 62471 62459 -12
- Misses 13593 13605 +12
🚀 New features to boost your workflow:
|
a1q123456
reviewed
May 12, 2026
godexsoft
approved these changes
May 12, 2026
a1q123456
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR adds an early detection of invalid currency issuer.
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)