Sponsored Content
Skip to content

refactor: Fill txJson based on apiVersion - #7109

Merged
bthomee merged 3 commits into
XRPLF:developfrom
rrmanukyan:refactor-fill-txjson-by-apiversion
May 12, 2026
Merged

refactor: Fill txJson based on apiVersion#7109
bthomee merged 3 commits into
XRPLF:developfrom
rrmanukyan:refactor-fill-txjson-by-apiversion

Conversation

@rrmanukyan

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Adjusts fillJsonQueue to populate txJson consistently with how
fillJsonTx represents transactions for the requested API version.

Type of Change

  • Refactor (non-breaking change that only restructures code)

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should
    only impact the next API version)
  • Public API: Non-breaking change (additional fields or fixes)
  • Public API: Test-only change (no impact to or change in behavior
    of existing APIs)

@codecov

codecov Bot commented May 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.1%. Comparing base (aa55392) to head (66ea84b).

Files with missing lines Patch % Lines
src/xrpld/app/ledger/detail/LedgerToJson.cpp 71.4% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #7109     +/-   ##
=========================================
- Coverage     82.1%   82.1%   -0.0%     
=========================================
  Files         1010    1010             
  Lines        76064   76068      +4     
  Branches      7375    7375             
=========================================
+ Hits         62470   62473      +3     
- Misses       13594   13595      +1     
Files with missing lines Coverage Δ
src/xrpld/app/ledger/detail/LedgerToJson.cpp 75.8% <71.4%> (-<0.1%) ⬇️

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pratikmankawde pratikmankawde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rrmanukyan rrmanukyan added this to the 3.1.3 milestone May 11, 2026
@bthomee bthomee modified the milestones: 3.1.3, 3.1.3 (develop) May 12, 2026
@bthomee

bthomee commented May 12, 2026

Copy link
Copy Markdown
Collaborator

@rrmanukyan is this ready to merge?

@rrmanukyan

Copy link
Copy Markdown
Contributor Author

@bthomee yes it is

@bthomee bthomee added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label May 12, 2026
@bthomee
bthomee added this pull request to the merge queue May 12, 2026
Merged via the queue into XRPLF:develop with commit 45b1f4d May 12, 2026
2 of 3 checks passed
@rrmanukyan
rrmanukyan deleted the refactor-fill-txjson-by-apiversion branch May 13, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants