Sponsored Content
Skip to content

style: Make .clang-tidy style a bit more consistent with Clio - #7096

Merged
bthomee merged 1 commit into
XRPLF:developfrom
mathbunnyru:cleanup_tidy_config
May 7, 2026
Merged

style: Make .clang-tidy style a bit more consistent with Clio#7096
bthomee merged 1 commit into
XRPLF:developfrom
mathbunnyru:cleanup_tidy_config

Conversation

@mathbunnyru

@mathbunnyru mathbunnyru commented May 7, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

The diff with Clio becomes more clear and it's quite evident we haven't forgotten any checks here or there:

140d139
<   readability-inconsistent-declaration-parameter-name,
152d150
<   readability-static-accessed-through-instance,
156a155,158
> # ---
> # readability-inconsistent-declaration-parameter-name, # in this codebase this check will break a lot of arg names
> # readability-static-accessed-through-instance,        # this check is probably unnecessary. it makes the code less readable
> # ---
162c164
<   misc-include-cleaner.IgnoreHeaders: '.*/(detail|impl)/.*;.*(expected|unexpected).*;.*ranges_lower_bound\.h;time.h;stdlib.h;__chrono/.*;fmt/chrono.h;boost/uuid/uuid_hash.hpp'
---
>   misc-include-cleaner.IgnoreHeaders: ".*/(detail|impl)/.*;.*fwd\\.h(pp)?;time.h;stdlib.h;sqlite3.h;netinet/in\\.h;sys/resource\\.h;sys/sysinfo\\.h;linux/sysinfo\\.h;__chrono/.*;bits/.*;_abort\\.h;boost/uuid/uuid_hash.hpp;boost/beast/core/flat_buffer\\.hpp;boost/beast/http/field\\.hpp;boost/beast/http/dynamic_body\\.hpp;boost/beast/http/message\\.hpp;boost/beast/http/read\\.hpp;boost/beast/http/write\\.hpp;openssl/obj_mac\\.h"
197c199
<   readability-identifier-naming.FunctionIgnoredRegexp: ".*tag_invoke.*"
---
>   readability-identifier-naming.GlobalFunctionIgnoredRegexp: "^(to_string|hash_append|tuple_hash)$"
199c201,202
< HeaderFilterRegex: '^.*/(src|tests)/.*\.(h|hpp)$'
---
> HeaderFilterRegex: '^.*/(test|xrpl|xrpld)/.*\.(h|hpp|ipp)$'
> ExcludeHeaderFilterRegex: '^.*/protocol_autogen/.*\.(h|hpp)$'

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Copilot AI review requested due to automatic review settings May 7, 2026 16:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s .clang-tidy configuration to better align its style/organization with Clio, without changing the effective set of configured options.

Changes:

  • Reorders and groups several CheckOptions entries near the top of the CheckOptions block.
  • Adds whitespace to improve readability and consistency of the config layout.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mathbunnyru
mathbunnyru requested a review from bthomee May 7, 2026 16:44
@mathbunnyru mathbunnyru added Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval. labels May 7, 2026
@codecov

codecov Bot commented May 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.1%. Comparing base (af89854) to head (8dbaf4e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #7096     +/-   ##
=========================================
- Coverage     82.1%   82.1%   -0.0%     
=========================================
  Files         1010    1010             
  Lines        76040   76040             
  Branches      7371    7371             
=========================================
- Hits         62423   62416      -7     
- Misses       13617   13624      +7     

see 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee
bthomee added this pull request to the merge queue May 7, 2026
Merged via the queue into XRPLF:develop with commit 4a9f72c May 7, 2026
3 checks passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants