chore: Add IWYU pragma for boost::optional to fix clang-tidy

[mathbunnyru]

High-Level Overview of Change

Needed after #7084
For some reason, clang-tidy thinks it's not needed, but it is - there are boost::optional in the code.

Context of Change

API Impact

• Public API: New feature (new methods and/or new fields)
• Public API: Breaking change (in general, breaking changes should only impact the next api_version)
• libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
• Peer protocol change (must be backward compatible or bump the peer protocol version)

[Copilot]

Pull request overview

This PR cleans up source and test files by removing boost/optional/optional.hpp includes that became unnecessary after the dependency upgrades in #7084.

Changes:

• Removes #include <boost/optional/optional.hpp> from several DB/SOCI-related implementation files.
• Removes the same include from a couple of unit tests to reduce redundant header usage.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/xrpld/app/rdb/detail/PeerFinder.cpp	Drops a Boost.Optional include from PeerFinder DB code.
src/xrpld/app/rdb/backend/detail/Node.cpp	Drops a Boost.Optional include from relational DB backend implementation.
src/xrpld/app/misc/detail/Transaction.cpp	Drops a Boost.Optional include from transaction SQL-loading implementation.
src/xrpld/app/misc/detail/AmendmentTable.cpp	Drops a Boost.Optional include from amendment-table implementation.
src/test/overlay/short_read_test.cpp	Drops a Boost.Optional include from an overlay/networking unit test.
src/test/core/SociDB_test.cpp	Drops a Boost.Optional include from SOCI DB unit tests.
src/libxrpl/server/Wallet.cpp	Drops a Boost.Optional include from wallet DB code.
src/libxrpl/server/State.cpp	Drops a Boost.Optional include from state DB code.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.1%. Comparing base (13b72a4) to head (eb115d6).

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #7088     +/-   ##
=========================================
- Coverage     82.1%   82.1%   -0.0%     
=========================================
  Files         1010    1010             
  Lines        76023   76023             
  Branches      7372    7367      -5     
=========================================
- Hits         62403   62401      -2     
- Misses       13620   13622      +2     

Files with missing lines	Coverage Δ
src/libxrpl/server/State.cpp	94.9% <ø> (ø)
src/libxrpl/server/Wallet.cpp	79.1% <ø> (ø)
src/xrpld/app/misc/detail/AmendmentTable.cpp	95.0% <ø> (ø)
src/xrpld/app/misc/detail/Transaction.cpp	82.3% <ø> (ø)
src/xrpld/app/rdb/backend/detail/Node.cpp	59.3% <ø> (ø)
src/xrpld/app/rdb/detail/PeerFinder.cpp	81.8% <ø> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

[godexsoft]

Thanks!