feat: Implement nix-based Dockerfile for CI - #7083
Merged
Merged
Conversation
kuznetsss
reviewed
May 7, 2026
mathbunnyru
force-pushed
the
nix_docker
branch
4 times, most recently
from
May 12, 2026 13:58
792fbc1 to
b405ab8
Compare
kuznetsss
reviewed
May 12, 2026
Closed
kuznetsss
reviewed
May 13, 2026
godexsoft
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
I implement nixos-packages build Docker images.
This allows us to have the following:
rippledAll that being said, we use
libcof the oldest distro we support.ubuntu:20.04hadlibc 2.31, so we have to:libcversiongccwith thislibclibstdc++as wellThis allows us to build binaries compatible with old OS, but have all the features of the modern compilers.
Current limitations (not going to be addressed in this PR, but will be resolved in the future):
linux/amd64gcc-15(clangwill be added later)cmake --versionin the image)The base builder image ends up being the same (nixos), so it gets rebuilt every time.
But let's not worry about it too much - it won't be updated very often, so it shouldn't be too much of a problem.
And it's all in parallel, so we should be good too.
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)