chore: Mark empty transactor invariants as future work - #7080
Merged
Conversation
Add a one-line comment in each transactor's empty visitInvariantEntry and finalizeInvariants to indicate the absence of transaction-specific invariants is intentional and tracked as future work, so static analysis and AI review tools stop flagging it.
Tapanito
added
the
Trivial
![xrplf-ai-reviewer[bot]](https://avatars.githubusercontent.com/u/67929741?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7080 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.0%
=========================================
Files 1010 1010
Lines 76024 76024
Branches 7383 7372 -11
=========================================
- Hits 62401 62394 -7
- Misses 13623 13630 +7
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
mvadari
approved these changes
May 6, 2026
Tapanito
added
the
Ready to merge
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Most transactors implement
visitInvariantEntry/finalizeInvariantsas no-ops — the absence of transaction-specific invariants is intentional and tracked as future work, but it consistently trips up static analysis and AI review tools that flag "this transaction has no invariants."This PR adds a single one-line comment in each empty body so reviewers and tooling can see at a glance that the empty implementation is deliberate:
// No transaction-specific invariants yet (future work).No behavior change — comment-only edit across 66 transactor
.cppfiles (covering 73 transactors;XChainBridge.cppalone defines 8).Test plan
SetRegularKey.cppcompiled as a smoke test; pure comment edits)pre-commithooks pass (clang-format, clang-tidy, cspell, etc.)