Sponsored Content
Skip to content

ci: Run pre-commit on diff in clang-tidy workflow - #7078

Merged
bthomee merged 3 commits into
XRPLF:developfrom
mathbunnyru:better_tidy_diff
May 5, 2026
Merged

ci: Run pre-commit on diff in clang-tidy workflow#7078
bthomee merged 3 commits into
XRPLF:developfrom
mathbunnyru:better_tidy_diff

Conversation

@mathbunnyru

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This:

  • works well when some problems are not automatically fix-able (we won't fail for the wrong reason)
  • gives a diff which already matches our style rules

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Copilot AI review requested due to automatic review settings May 5, 2026 14:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the reusable clang-tidy GitHub Actions workflow to (a) detect whether clang-tidy produced any working-tree changes and (b) optionally run pre-commit to apply style fixes so the uploaded patch better matches repository formatting rules.

Changes:

  • Adds a “Check for changes” step to detect whether clang-tidy produced a diff.
  • Runs pre-commit style fixes when changes are detected, and switches diff artifact generation/upload gating to the “files changed” result.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/reusable-clang-tidy.yml Outdated
Comment thread .github/workflows/reusable-clang-tidy.yml
Comment thread .github/workflows/reusable-clang-tidy.yml
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 5, 2026 14:34
@mathbunnyru mathbunnyru added Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval. labels May 5, 2026

@godexsoft godexsoft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:rage4:

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/reusable-clang-tidy.yml
Comment thread .github/workflows/reusable-clang-tidy.yml
@codecov

codecov Bot commented May 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.1%. Comparing base (e092c52) to head (c3ab4fd).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #7078   +/-   ##
=======================================
  Coverage     82.1%   82.1%           
=======================================
  Files         1010    1010           
  Lines        76033   76033           
  Branches      7369    7366    -3     
=======================================
  Hits         62413   62413           
  Misses       13620   13620           

see 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee
bthomee added this pull request to the merge queue May 5, 2026
Merged via the queue into XRPLF:develop with commit 6e6fb9c May 5, 2026
3 checks passed
oleks-rip pushed a commit to oleks-rip/rippled that referenced this pull request May 5, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants