Sponsored Content
Skip to content

ci: Use XRPLF/create-issue - #7076

Merged
bthomee merged 2 commits into
XRPLF:developfrom
mathbunnyru:use_create_issue
May 5, 2026
Merged

ci: Use XRPLF/create-issue#7076
bthomee merged 2 commits into
XRPLF:developfrom
mathbunnyru:use_create_issue

Conversation

@mathbunnyru

Copy link
Copy Markdown
Contributor

High Level Overview of Change

I decided to create a separate create-issue action, because we use it quite a lot.
So, let's use it here.
This simplifies the code, and makes it quite straightforward.

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mathbunnyru
mathbunnyru requested review from Copilot and godexsoft and removed request for Copilot May 5, 2026 12:00
@mathbunnyru mathbunnyru added Trivial Simple change with minimal effect, or already tested. Only needs one approval. Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. labels May 5, 2026
@codecov

codecov Bot commented May 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.1%. Comparing base (d050073) to head (93bb163).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #7076     +/-   ##
=========================================
- Coverage     82.1%   82.1%   -0.0%     
=========================================
  Files         1010    1010             
  Lines        76033   76033             
  Branches      7379    7368     -11     
=========================================
- Hits         62426   62411     -15     
- Misses       13607   13622     +15     

see 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@godexsoft godexsoft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 :rage2:

@bthomee
bthomee added this pull request to the merge queue May 5, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 5, 2026
Copilot AI review requested due to automatic review settings May 5, 2026 13:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the reusable clang-tidy GitHub Actions workflow to use the shared XRPLF/actions/create-issue action for failure issue creation, reducing bespoke shell logic and removing the separate “create-issue-on-failure” job.

Changes:

  • Switch clang-tidy failure issue creation from gh issue create + artifact handoff to XRPLF/actions/create-issue.
  • Simplify the generated issue body content and keep only filtered clang-tidy output.
  • Add godexsoft to the cspell allowlist to avoid spellcheck noise for the new assignee configuration.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
cspell.config.yaml Adds a GitHub username to the spellchecker allowlist used in CI/config files.
.github/workflows/reusable-clang-tidy.yml Replaces custom issue-creation job/logic with XRPLF/actions/create-issue and adjusts permissions/issue body content.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/reusable-clang-tidy.yml
Comment thread .github/workflows/reusable-clang-tidy.yml
Comment thread .github/workflows/reusable-clang-tidy.yml
@bthomee
bthomee enabled auto-merge May 5, 2026 13:37
@bthomee
bthomee added this pull request to the merge queue May 5, 2026
Merged via the queue into XRPLF:develop with commit e092c52 May 5, 2026
3 checks passed
oleks-rip pushed a commit to oleks-rip/rippled that referenced this pull request May 5, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants