Sponsored Content
Skip to content

fix: Fix multisign and signfor to check for delegate - #7064

Merged
bthomee merged 6 commits into
XRPLF:developfrom
yinyiqian1:fix-perm-multisign
May 20, 2026
Merged

fix: Fix multisign and signfor to check for delegate#7064
bthomee merged 6 commits into
XRPLF:developfrom
yinyiqian1:fix-perm-multisign

Conversation

@yinyiqian1

Copy link
Copy Markdown
Contributor

In multisign and signfor operations, an account is not permitted to sign its own transaction.
Similarly, in a delegation transaction, the sfDelegate cannot sign the transaction it is submitting on behalf of another account.

High Level Overview of Change

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@codecov

codecov Bot commented May 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.1%. Comparing base (93ac1aa) to head (f578e94).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #7064     +/-   ##
=========================================
- Coverage     82.1%   82.1%   -0.0%     
=========================================
  Files         1010    1010             
  Lines        76167   76167             
  Branches      7423    7412     -11     
=========================================
- Hits         62514   62506      -8     
- Misses       13653   13661      +8     
Files with missing lines Coverage Δ
src/libxrpl/protocol/STTx.cpp 88.1% <100.0%> (ø)
src/xrpld/rpc/detail/TransactionSign.cpp 89.1% <100.0%> (ø)

... and 5 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented May 3, 2026

Copy link
Copy Markdown

This PR has conflicts, please resolve them in order for the PR to be reviewed.

@godexsoft

Copy link
Copy Markdown
Contributor

We recently merged a refactor to develop that enables clang-tidy's readability-identifier-naming. Your branch now has heavy conflicts that are largely mechanical. Below is a workflow that aligns your branch's naming with develop before merging, which should minimize the merge conflicts.

One-time setup

If you don't already have clang-tidy working in your env, on macOS:

brew install llvm@21
# Follow brew's hint to put $(brew --prefix llvm@21)/bin on PATH so run-clang-tidy is found.

Workflow on your branch (before merging develop)

1. Grab the new .clang-tidy from develop without pulling anything else. Sync your fork on GitHub first, then:

git remote -v   # should show 'upstream' among others; if not:
# git remote set-url upstream git@github.com:XRPLF/rippled.git
git fetch upstream
git checkout upstream/develop -- .clang-tidy

2. Reconfigure conan/cmake so compile_commands.json is fresh.

3. Apply renames for the files modified in your PR:

git diff --name-only $(git merge-base HEAD upstream/develop) HEAD \
  | grep -E '\.(cpp|h|hpp|ipp)$' \
  | xargs run-clang-tidy -p build -fix -allow-no-checks
# or -p .build, or whatever your build dir is called

4. Build + test, then commit as a single dedicated commit:

cmake --build build -j8
git commit -am "refactor: Align identifier naming with develop"

5. Now merge develop:

git merge upstream/develop

Extra

Run clang-tidy once more after the merge to catch any stragglers introduced from develop's side:

run-clang-tidy -p build -fix -allow-no-checks src tests
# or -p .build, or whatever your build dir is called

@yinyiqian1
yinyiqian1 force-pushed the fix-perm-multisign branch from 3beb032 to 10f5cfc Compare May 7, 2026 18:27
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

All conflicts have been resolved. Assigned reviewers can now start or resume their review.

@yinyiqian1
yinyiqian1 force-pushed the fix-perm-multisign branch from ecf7859 to 981e2d7 Compare May 7, 2026 21:13
@yinyiqian1
yinyiqian1 requested a review from PeterChen13579 May 11, 2026 15:49

@PeterChen13579 PeterChen13579 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

Comment thread src/libxrpl/protocol/STTx.cpp Outdated
Comment thread src/test/app/Delegate_test.cpp Outdated
Comment thread src/test/app/Delegate_test.cpp

@PeterChen13579 PeterChen13579 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yinyiqian1 yinyiqian1 added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label May 15, 2026
Comment thread src/libxrpl/protocol/STTx.cpp Outdated
Comment thread src/libxrpl/protocol/STTx.cpp
@bthomee
bthomee enabled auto-merge May 20, 2026 19:49
@bthomee
bthomee added this pull request to the merge queue May 20, 2026
Merged via the queue into XRPLF:develop with commit 9cb0740 May 20, 2026
3 checks passed
Kassaking7 pushed a commit to Kassaking7/rippled that referenced this pull request Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants