Sponsored Content
Skip to content

ci: Use print-env from XRPLF/actions - #7052

Merged
bthomee merged 1 commit into
XRPLF:developfrom
mathbunnyru:print_env_act
Apr 29, 2026
Merged

ci: Use print-env from XRPLF/actions#7052
bthomee merged 1 commit into
XRPLF:developfrom
mathbunnyru:print_env_act

Conversation

@mathbunnyru

@mathbunnyru mathbunnyru commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

It has been added here: XRPLF/actions#96
So, we should use shared action.

Also updated other actions, but these changes are minor.

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mathbunnyru
mathbunnyru requested review from bthomee and Copilot April 29, 2026 16:48
@mathbunnyru mathbunnyru added Trivial Simple change with minimal effect, or already tested. Only needs one approval. Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. labels Apr 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CI workflows to use the shared print-env GitHub Action from XRPLF/actions instead of maintaining a local composite action in this repo, reducing duplication and centralizing maintenance.

Changes:

  • Switch workflow steps from ./.github/actions/print-env to XRPLF/actions/print-env@<pinned_sha>.
  • Remove the local .github/actions/print-env composite action and its Dependabot entry.
  • Bump the referenced XRPLF/actions reusable pre-commit workflow SHA.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/upload-conan-deps.yml Uses shared XRPLF/actions/print-env instead of local action.
.github/workflows/reusable-clang-tidy-files.yml Uses shared XRPLF/actions/print-env instead of local action.
.github/workflows/reusable-build-test-config.yml Uses shared XRPLF/actions/print-env instead of local action.
.github/workflows/pre-commit.yml Updates the pinned SHA for the reusable pre-commit workflow from XRPLF/actions.
.github/dependabot.yml Removes Dependabot tracking for deleted local print-env action directory.
.github/actions/print-env/action.yml Deletes the local print-env composite action implementation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/pre-commit.yml
@bthomee
bthomee enabled auto-merge April 29, 2026 17:00
@codecov

codecov Bot commented Apr 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.0%. Comparing base (f7275b7) to head (8690bcd).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #7052     +/-   ##
=========================================
- Coverage     82.1%   82.0%   -0.0%     
=========================================
  Files         1010    1010             
  Lines        75994   75994             
  Branches      7388    7382      -6     
=========================================
- Hits         62355   62351      -4     
- Misses       13639   13643      +4     

see 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee
bthomee added this pull request to the merge queue Apr 29, 2026
Merged via the queue into XRPLF:develop with commit 6ae090b Apr 29, 2026
3 checks passed
marek-foss-neti pushed a commit to marek-foss-neti/rippled that referenced this pull request May 5, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants