fix: Backport Permissioned Domains fixes

[oleks-rip]

High Level Overview of Change

Some fixes for Permissioned Domains that where applied to staging-3.1.3 but not present in develop

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.1%. Comparing base (551f3c3) to head (453e482).

Additional details and impacted files

@@           Coverage Diff           @@
##           develop   #7016   +/-   ##
=======================================
  Coverage     82.1%   82.1%           
=======================================
  Files         1010    1010           
  Lines        76205   76205           
  Branches      7407    7401    -6     
=======================================
  Hits         62571   62571           
  Misses       13634   13634           

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[vlntb]

Worth calling out in the PR description that withFix_ and withFeature_ were identical before this change — that's the actual substantive fix here.

[github-actions]

This PR has conflicts, please resolve them in order for the PR to be reviewed.

[godexsoft]

We recently merged a refactor to develop that enables clang-tidy's readability-identifier-naming. Your branch now has heavy conflicts that are largely mechanical. Below is a workflow that aligns your branch's naming with develop before merging, which should minimize the merge conflicts.

One-time setup

If you don't already have clang-tidy working in your env, on macOS:

brew install llvm@21
# Follow brew's hint to put $(brew --prefix llvm@21)/bin on PATH so run-clang-tidy is found.

Workflow on your branch (before merging develop)

1. Grab the new .clang-tidy from develop without pulling anything else. Sync your fork on GitHub first, then:

git remote -v   # should show 'upstream' among others; if not:
# git remote set-url upstream git@github.com:XRPLF/rippled.git
git fetch upstream
git checkout upstream/develop -- .clang-tidy

2. Reconfigure conan/cmake so compile_commands.json is fresh.

3. Apply renames for the files modified in your PR:

git diff --name-only $(git merge-base HEAD upstream/develop) HEAD \
  | grep -E '\.(cpp|h|hpp|ipp)$' \
  | xargs run-clang-tidy -p build -fix -allow-no-checks
# or -p .build, or whatever your build dir is called

4. Build + test, then commit as a single dedicated commit:

cmake --build build -j8
git commit -am "refactor: Align identifier naming with develop"

5. Now merge develop:

git merge upstream/develop

Extra

Run clang-tidy once more after the merge to catch any stragglers introduced from develop's side:

run-clang-tidy -p build -fix -allow-no-checks src tests
# or -p .build, or whatever your build dir is called

[github-actions]

All conflicts have been resolved. Assigned reviewers can now start or resume their review.

[bthomee]

The featurePermissionedDomains, featureCredentials, and fixPermissionedDomainInvariant amendments are marked as being supported in features.macro, so are included in testableAmendments() by default. In essence, the list above translates to:

• without feature: all amendments minus permissioned domains and invariant.
• with feature: all amendments minus invariant.
• with fix: all amendments.

Is a separate FeatureBitset needed for "all amendments minus permissioned domains" (so, including the invariant)?

[oleks-rip]

This code is moved from another branch, and, probably, written before amendments were accepted. So it is here in this form just to be the same, and to provide exact clarity on which amendments enabled / disabed

[bthomee]

After looking more closely, the way the current tests are set up, and where these withX and withoutX are referenced, I notice my source of feeling uneasy with the current code (not your changes specifically).

I suggest to simply remove the withoutFeature_ completely. It's only used in one location, on line 101. You can just replace the withoutFeature_ there by testableAmendments() - featurePermissionedDomains.

Then you can keep everything else as-is for now. I think adding more combinations would make sense, to make sure nothing breaks if the fix is enabled but the amendment isn't, for instance. It's unlikely Credentials will become unsupported, so you probably don't have to test for that.

[oleks-rip]

removed

[bthomee]

Very nice, thanks for making the changes.