chore: Enable clang-tidy modernize-use-nodiscard check - #7015
Merged
Conversation
godexsoft
commented
Apr 24, 2026
| struct CheckpointerSetup | ||
| { | ||
| JobQueue* jobQueue{}; | ||
| std::reference_wrapper<ServiceRegistry> registry; |
Contributor
Author
There was a problem hiding this comment.
clang-tidy wanted to add '{}' here but this does not compile so we disable it with the nolint above.
Collaborator
There was a problem hiding this comment.
Yeah I had to do the same in my own PR.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the modernize-use-nodiscard clang-tidy check and applies the resulting automated updates across the codebase by adding [[nodiscard]] to many return-valued functions (notably getters and query helpers) to help catch ignored return values at compile time.
Changes:
- Enable
modernize-use-nodiscardin.clang-tidy. - Add
[[nodiscard]]annotations across xrpld, libxrpl, public headers, and test utilities. - Update numerous interfaces/overrides so their return values are consistently marked
[[nodiscard]].
Reviewed changes
Copilot reviewed 276 out of 276 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/xrpld/shamap/NodeFamily.h | Add [[nodiscard]] to const DB accessor |
| src/xrpld/rpc/handlers/server_info/ServerDefinitions.cpp | Add [[nodiscard]] to hash/JSON accessors |
| src/xrpld/rpc/detail/WSInfoSub.h | Add [[nodiscard]] to request metadata accessors |
| src/xrpld/rpc/detail/TransactionSign.cpp | Add [[nodiscard]] to signing parameter accessors |
| src/xrpld/rpc/detail/MPT.h | Add [[nodiscard]] to MPT helpers |
| src/xrpld/rpc/detail/LegacyPathFind.h | Add [[nodiscard]] to status accessor |
| src/xrpld/rpc/detail/AssetCache.h | Add [[nodiscard]] to cache accessors/hash |
| src/xrpld/rpc/Status.h | Add [[nodiscard]] to status conversion/accessors |
| src/xrpld/rpc/ServerHandler.h | Add [[nodiscard]] to accessors and response factory |
| src/xrpld/peerfinder/detail/Handouts.h | Add [[nodiscard]] to handout accessors |
| src/xrpld/peerfinder/detail/Fixed.h | Add [[nodiscard]] to time accessor |
| src/xrpld/peerfinder/detail/Bootcache.h | Add [[nodiscard]] to cache accessors/iterators |
| src/xrpld/peerfinder/Slot.h | Add [[nodiscard]] to slot query interface |
| src/xrpld/peerfinder/PeerfinderManager.h | Add [[nodiscard]] to config calculation |
| src/xrpld/overlay/detail/ZeroCopyStream.h | Add [[nodiscard]] to ByteCount overrides |
| src/xrpld/overlay/detail/TrafficCount.h | Add [[nodiscard]] to counts accessor |
| src/xrpld/overlay/detail/PeerSet.cpp | Add [[nodiscard]] to peer id accessors |
| src/xrpld/overlay/Slot.h | Add [[nodiscard]] to slot state/query accessors |
| src/xrpld/overlay/PeerSet.h | Add [[nodiscard]] to peer id accessor |
| src/xrpld/overlay/Peer.h | Add [[nodiscard]] to various peer query APIs |
| src/xrpld/overlay/Overlay.h | Add [[nodiscard]] to overlay query APIs |
| src/xrpld/overlay/ClusterNode.h | Add [[nodiscard]] to cluster node accessors |
| src/xrpld/core/NetworkIDServiceImpl.h | Add [[nodiscard]] to network id accessor |
| src/xrpld/core/Config.h | Add [[nodiscard]] to config accessors/utilities |
| src/xrpld/consensus/Validations.h | Add [[nodiscard]] to seq accessor |
| src/xrpld/consensus/DisputedTx.h | Add [[nodiscard]] to dispute accessors/JSON |
| src/xrpld/consensus/ConsensusTypes.h | Add [[nodiscard]] to timer read accessor |
| src/xrpld/consensus/Consensus.h | Add [[nodiscard]] to state/query helpers |
| src/xrpld/app/misc/detail/AmendmentTable.cpp | Add [[nodiscard]] to vote/query helpers |
| src/xrpld/app/misc/ValidatorList.h | Add [[nodiscard]] to disposition accessors |
| src/xrpld/app/misc/ValidatorKeys.h | Add [[nodiscard]] to config status accessor |
| src/xrpld/app/misc/TxQ.h | Add [[nodiscard]] to queue accessors/detail helpers |
| src/xrpld/app/misc/Transaction.h | Add [[nodiscard]] to state/query helpers |
| src/xrpld/app/misc/SHAMapStore.h | Add [[nodiscard]] to store query interface |
| src/xrpld/app/misc/FeeVoteImpl.cpp | Add [[nodiscard]] to votable accessors |
| src/xrpld/app/main/Main.cpp | Add [[nodiscard]] to selector size accessor |
| src/xrpld/app/main/GRPCServer.h | Add [[nodiscard]] to endpoint accessors |
| src/xrpld/app/main/BasicApp.h | Add [[nodiscard]] to thread count accessor |
| src/xrpld/app/main/Application.h | Add [[nodiscard]] to application query APIs |
| src/xrpld/app/ledger/detail/LocalTxs.cpp | Add [[nodiscard]] to local-tx accessors |
| src/xrpld/app/ledger/TransactionStateSF.h | Add [[nodiscard]] to getNode override |
| src/xrpld/app/ledger/LedgerReplayTask.h | Add [[nodiscard]] to merge-check helper |
| src/xrpld/app/ledger/LedgerReplay.h | Add [[nodiscard]] to replay accessors |
| src/xrpld/app/ledger/ConsensusTransSetSF.h | Add [[nodiscard]] to getNode override |
| src/xrpld/app/ledger/AccountStateSF.h | Add [[nodiscard]] to getNode override |
| src/xrpld/app/ledger/AcceptedLedger.h | Add [[nodiscard]] to ledger/iterator accessors |
| src/xrpld/app/consensus/RCLCxTx.h | Add [[nodiscard]] to tx set/query accessors |
| src/xrpld/app/consensus/RCLCxLedger.h | Add [[nodiscard]] to ledger accessors/JSON |
| src/tests/libxrpl/net/HTTPClient.cpp | Add [[nodiscard]] to test server accessors |
| src/test/unit_test/multi_runner.h | Add [[nodiscard]] to result counters |
| src/test/unit_test/SuiteJournal.h | Add [[nodiscard]] to Sink::active override |
| src/test/unit_test/FileDirGuard.h | Add [[nodiscard]] to path/status accessors |
| src/test/shamap/common.h | Add [[nodiscard]] to DB accessor override |
| src/test/shamap/FetchPack_test.cpp | Add [[nodiscard]] to getNode override |
| src/test/rpc/DeliveredAmount_test.cpp | Add [[nodiscard]] to test checker |
| src/test/overlay/short_read_test.cpp | Add [[nodiscard]] to endpoint accessor |
| src/test/overlay/reduce_relay_test.cpp | Add [[nodiscard]] to PeerPartial accessors |
| src/test/jtx/xchain_bridge.h | Add [[nodiscard]] to bridge builder |
| src/test/jtx/vault.h | Add [[nodiscard]] to tx/keylet builder |
| src/test/jtx/mpt.h | Add [[nodiscard]] to test helper accessors |
| src/test/jtx/impl/WSClient.cpp | Add [[nodiscard]] to version accessor |
| src/test/jtx/impl/JSONRPCClient.cpp | Add [[nodiscard]] to version accessor |
| src/test/jtx/deposit.h | Add [[nodiscard]] to JSON conversion helpers |
| src/test/jtx/batch.h | Add [[nodiscard]] to txn accessor |
| src/test/jtx/basic_prop.h | Add [[nodiscard]] to clone interface |
| src/test/jtx/amount.h | Add [[nodiscard]] to pretty accessors (note: duplicates present) |
| src/test/jtx/TestHelpers.h | Add [[nodiscard]] to field value accessors |
| src/test/jtx/PathSet.h | Add [[nodiscard]] to JSON renderers |
| src/test/jtx/Oracle.h | Add [[nodiscard]] to accessors/ledgerEntry |
| src/test/jtx/JTx.h | Add [[nodiscard]] to property getter (note: duplicates present) |
| src/test/jtx/Account.h | Add [[nodiscard]] to account accessors |
| src/test/jtx/AbstractClient.h | Add [[nodiscard]] to version accessor |
| src/test/jtx/AMM.h | Add [[nodiscard]] to AMM test helpers |
| src/test/csf/submitters.h | Add [[nodiscard]] to rate helper |
| src/test/csf/ledgers.h | Add [[nodiscard]] to ledger/oracle accessors |
| src/test/csf/collectors.h | Add [[nodiscard]] to collector counters |
| src/test/csf/Validation.h | Add [[nodiscard]] to validation accessors |
| src/test/csf/Tx.h | Add [[nodiscard]] to tx/txset accessors |
| src/test/csf/TrustGraph.h | Add [[nodiscard]] to graph queries |
| src/test/csf/Scheduler.h | Add [[nodiscard]] to queue query |
| src/test/csf/PeerGroup.h | Add [[nodiscard]] to iterators/size |
| src/test/csf/Peer.h | Add [[nodiscard]] to delay helpers (note: duplicates present) |
| src/test/csf/Histogram.h | Add [[nodiscard]] to statistic accessors |
| src/test/csf/Digraph.h | Add [[nodiscard]] to graph query helpers |
| src/test/csf/BasicNetwork.h | Add [[nodiscard]] to graph accessor |
| src/test/core/Workers_test.cpp | Add [[nodiscard]] to PerfLog test overrides |
| src/test/core/Config_test.cpp | Add [[nodiscard]] to test guard accessors |
| src/test/consensus/Validations_test.cpp | Add [[nodiscard]] to helper accessors/factories |
| src/test/consensus/NegativeUNL_test.cpp | Add [[nodiscard]] to ledger accessor |
| src/test/beast/beast_Zero_test.cpp | Add [[nodiscard]] to signum helper |
| src/test/beast/beast_Journal_test.cpp | Add [[nodiscard]] to counter accessor |
| src/test/basics/hardened_hash_test.cpp | Add [[nodiscard]] to data accessor |
| src/test/app/XChain_test.cpp | Add [[nodiscard]] to test helper accessors |
| src/test/app/PayStrand_test.cpp | Add [[nodiscard]] to helper accessors |
| src/test/app/Loan_test.cpp | Add [[nodiscard]] to helper accessors |
| src/test/app/FlowMPT_test.cpp | Add [[nodiscard]] to expectation helpers |
| src/libxrpl/tx/transactors/bridge/XChainBridge.cpp | Add [[nodiscard]] to result helpers |
| src/libxrpl/tx/paths/OfferStream.cpp | Add [[nodiscard]] to helper (note: duplicates present) |
| src/libxrpl/protocol/SecretKey.cpp | Add [[nodiscard]] to tweak calculation |
| src/libxrpl/protocol/Rules.cpp | Add [[nodiscard]] to rule queries/accessors |
| src/libxrpl/nodestore/backend/RocksDBFactory.cpp | Add [[nodiscard]] to factory name |
| src/libxrpl/nodestore/backend/NullFactory.cpp | Add [[nodiscard]] to backend/factory queries |
| src/libxrpl/nodestore/backend/NuDBFactory.cpp | Add [[nodiscard]] to factory name |
| src/libxrpl/nodestore/backend/MemoryFactory.cpp | Add [[nodiscard]] to factory/backend queries |
| src/libxrpl/ledger/OpenView.cpp | Add [[nodiscard]] to iterator virtuals |
| src/libxrpl/ledger/Ledger.cpp | Add [[nodiscard]] to iterator virtuals |
| src/libxrpl/json/Writer.cpp | Add [[nodiscard]] to writer state/output accessors |
| src/libxrpl/conditions/error.cpp | Add [[nodiscard]] to error_category overrides |
| src/libxrpl/beast/utility/beast_Journal.cpp | Add [[nodiscard]] to Sink overrides |
| src/libxrpl/basics/Number.cpp | Add [[nodiscard]] to Guard queries |
| include/xrpl/tx/transactors/dex/AMMContext.h | Add [[nodiscard]] to context accessors |
| include/xrpl/tx/paths/detail/StrandFlow.h | Add [[nodiscard]] to ActiveStrands accessors |
| include/xrpl/tx/paths/detail/FlowDebugInfo.h | Add [[nodiscard]] to debug info helpers |
| include/xrpl/tx/paths/RippleCalc.h | Add [[nodiscard]] to result accessor |
| include/xrpl/tx/paths/OfferStream.h | Add [[nodiscard]] to offer stream accessors |
| include/xrpl/tx/paths/Offer.h | Add [[nodiscard]] to offer accessors/helpers |
| include/xrpl/tx/paths/BookTip.h | Add [[nodiscard]] to book tip accessors |
| include/xrpl/tx/paths/AMMOffer.h | Add [[nodiscard]] to AMM offer accessors/helpers |
| include/xrpl/tx/paths/AMMLiquidity.h | Add [[nodiscard]] to liquidity queries/helpers |
| include/xrpl/tx/invariants/NFTInvariant.h | Add [[nodiscard]] to finalize results |
| include/xrpl/tx/invariants/MPTInvariant.h | Add [[nodiscard]] to finalize results |
| include/xrpl/tx/invariants/InvariantCheck.h | Add [[nodiscard]] to finalize results |
| include/xrpl/tx/invariants/AMMInvariant.h | Add [[nodiscard]] to invariant helpers |
| include/xrpl/tx/applySteps.h | Add [[nodiscard]] to TxConsequences accessors |
| include/xrpl/tx/Transactor.h | Add [[nodiscard]] to view accessor |
| include/xrpl/tx/ApplyContext.h | Add [[nodiscard]] to view/flags accessors |
| include/xrpl/shamap/detail/TaggedPointer.h | Add [[nodiscard]] to child index helper |
| include/xrpl/shamap/SHAMapSyncFilter.h | Add [[nodiscard]] to getNode interface |
| include/xrpl/shamap/SHAMapNodeID.h | Add [[nodiscard]] to ID helpers |
| include/xrpl/shamap/SHAMapAddNode.h | Add [[nodiscard]] to status/accessors |
| include/xrpl/shamap/Family.h | Add [[nodiscard]] to const db() |
| include/xrpl/server/detail/io_list.h | Add [[nodiscard]] to closed() |
| include/xrpl/server/detail/Door.h | Add [[nodiscard]] to endpoint accessor |
| include/xrpl/server/detail/BaseWSPeer.h | Add [[nodiscard]] to session accessors |
| include/xrpl/server/WSSession.h | Add [[nodiscard]] to session accessors |
| include/xrpl/server/Port.h | Add [[nodiscard]] to port queries/helpers |
| include/xrpl/server/NetworkOPs.h | Add [[nodiscard]] to network info queries |
| include/xrpl/server/Manifest.h | Add [[nodiscard]] to manifest helpers |
| include/xrpl/server/InfoSub.h | Add [[nodiscard]] to accessors |
| include/xrpl/server/Handoff.h | Add [[nodiscard]] to handled() |
| include/xrpl/resource/detail/Entry.h | Add [[nodiscard]] to helpers |
| include/xrpl/resource/Consumer.h | Add [[nodiscard]] to query accessors |
| include/xrpl/resource/Charge.h | Add [[nodiscard]] to charge accessors |
| include/xrpl/rdb/SociDB.h | Add [[nodiscard]] to connectionString() |
| include/xrpl/rdb/DatabaseCon.h | Add [[nodiscard]] and a NOLINT note |
| include/xrpl/protocol/detail/token_errors.h | Add [[nodiscard]] to error_category overrides |
| include/xrpl/protocol/detail/STVar.h | Add [[nodiscard]] to accessors |
| include/xrpl/protocol/XRPAmount.h | Add [[nodiscard]] to helpers (note: duplicates present) |
| include/xrpl/protocol/XChainAttestations.h | Add [[nodiscard]] to verification/match/accessors |
| include/xrpl/protocol/Units.h | Add [[nodiscard]] to unit helpers |
| include/xrpl/protocol/TxMeta.h | Add [[nodiscard]] to metadata accessors |
| include/xrpl/protocol/Serializer.h | Add [[nodiscard]] to buffer accessors |
| include/xrpl/protocol/SeqProxy.h | Add [[nodiscard]] to proxy queries |
| include/xrpl/protocol/Seed.h | Add [[nodiscard]] to accessors/iterators |
| include/xrpl/protocol/SecretKey.h | Add [[nodiscard]] to accessors/iterators |
| include/xrpl/protocol/STXChainBridge.h | Add [[nodiscard]] to ST helpers |
| include/xrpl/protocol/STVector256.h | Add [[nodiscard]] to accessors |
| include/xrpl/protocol/STNumber.h | Add [[nodiscard]] to accessors/queries |
| include/xrpl/protocol/STLedgerEntry.h | Add [[nodiscard]] to accessors/queries |
| include/xrpl/protocol/STIssue.h | Add [[nodiscard]] to accessors/queries |
| include/xrpl/protocol/STInteger.h | Add [[nodiscard]] to accessors/queries |
| include/xrpl/protocol/STCurrency.h | Add [[nodiscard]] to accessors/queries |
| include/xrpl/protocol/STBlob.h | Add [[nodiscard]] to accessors/queries |
| include/xrpl/protocol/STBitString.h | Add [[nodiscard]] to accessors/queries |
| include/xrpl/protocol/STBase.h | Add [[nodiscard]] to virtuals/helpers |
| include/xrpl/protocol/STArray.h | Add [[nodiscard]] to accessors/queries |
| include/xrpl/protocol/STAmount.h | Add [[nodiscard]] to accessors/conversions |
| include/xrpl/protocol/STAccount.h | Add [[nodiscard]] to accessors/queries |
| include/xrpl/protocol/SOTemplate.h | Add [[nodiscard]] to accessors/iterators |
| include/xrpl/protocol/SField.h | Add [[nodiscard]] to accessors/queries |
| include/xrpl/protocol/Rules.h | Add [[nodiscard]] to rule queries/accessors |
| include/xrpl/protocol/QualityFunction.h | Add [[nodiscard]] to accessors |
| include/xrpl/protocol/Quality.h | Add [[nodiscard]] to helpers |
| include/xrpl/protocol/PublicKey.h | Add [[nodiscard]] to accessors/iterators |
| include/xrpl/protocol/Permissions.h | Add [[nodiscard]] to query helpers |
| include/xrpl/protocol/PathAsset.h | Add [[nodiscard]] to accessors/queries |
| include/xrpl/protocol/MultiApiJson.h | Add [[nodiscard]] to visit overloads (note: duplicates present) |
| include/xrpl/protocol/MPTIssue.h | Add [[nodiscard]] to accessors |
| include/xrpl/protocol/MPTAmount.h | Add [[nodiscard]] to accessors |
| include/xrpl/protocol/KnownFormats.h | Add [[nodiscard]] to format lookup/accessors |
| include/xrpl/protocol/Keylet.h | Add [[nodiscard]] to check() |
| include/xrpl/protocol/Issue.h | Add [[nodiscard]] to accessors/queries |
| include/xrpl/protocol/InnerObjectFormats.h | Add [[nodiscard]] to template lookup |
| include/xrpl/protocol/IOUAmount.h | Add [[nodiscard]] to accessors |
| include/xrpl/protocol/Fees.h | Add [[nodiscard]] to reserve calculator |
| include/xrpl/protocol/Asset.h | Add [[nodiscard]] to accessors/queries |
| include/xrpl/nodestore/detail/DecodedBlob.h | Add [[nodiscard]] to wasOk() |
| include/xrpl/nodestore/NodeObject.h | Add [[nodiscard]] to accessors |
| include/xrpl/nodestore/Factory.h | Add [[nodiscard]] to getName() |
| include/xrpl/nodestore/Backend.h | Add [[nodiscard]] to queries |
| include/xrpl/net/HTTPClientSSLContext.h | Add [[nodiscard]] to sslVerify() |
| include/xrpl/net/AutoSocket.h | Add [[nodiscard]] to isSecure() |
| include/xrpl/ledger/helpers/LendingHelpers.h | Add [[nodiscard]] to numeric helpers |
| include/xrpl/ledger/detail/ReadViewFwdRange.h | Add [[nodiscard]] to iterator virtuals |
| include/xrpl/ledger/detail/RawStateTable.h | Add [[nodiscard]] to queries/accessors |
| include/xrpl/ledger/detail/ApplyViewBase.h | Add [[nodiscard]] to ReadView/ApplyView overrides |
| include/xrpl/ledger/detail/ApplyStateTable.h | Add [[nodiscard]] to queries/accessors |
| include/xrpl/ledger/PaymentSandbox.h | Add [[nodiscard]] to query helpers |
| include/xrpl/ledger/Dir.h | Add [[nodiscard]] to iterators |
| include/xrpl/ledger/CanonicalTXSet.h | Add [[nodiscard]] to accessors/iterators |
| include/xrpl/ledger/BookDirs.h | Add [[nodiscard]] to iterators |
| include/xrpl/ledger/ApplyView.h | Add [[nodiscard]] to flags() |
| include/xrpl/ledger/AmendmentTable.h | Add [[nodiscard]] to query APIs |
| include/xrpl/ledger/AcceptedLedgerTx.h | Add [[nodiscard]] to accessors |
| include/xrpl/json/json_reader.h | Add [[nodiscard]] to error message getter |
| include/xrpl/json/JsonPropertyStream.h | Add [[nodiscard]] to top() |
| include/xrpl/core/ServiceRegistry.h | Add [[nodiscard]] to query APIs |
| include/xrpl/core/PerfLog.h | Add [[nodiscard]] to JSON accessors |
| include/xrpl/core/PeerReservationTable.h | Add [[nodiscard]] to toJson() |
| include/xrpl/core/NetworkIDService.h | Add [[nodiscard]] to getNetworkID() |
| include/xrpl/core/LoadEvent.h | Add [[nodiscard]] to accessors |
| include/xrpl/core/JobTypes.h | Add [[nodiscard]] to accessors/iterators |
| include/xrpl/core/JobTypeInfo.h | Add [[nodiscard]] to accessors |
| include/xrpl/core/JobTypeData.h | Add [[nodiscard]] to accessors |
| include/xrpl/core/Job.h | Add [[nodiscard]] to accessors |
| include/xrpl/core/HashRouter.h | Add [[nodiscard]] to accessors |
| include/xrpl/conditions/detail/PreimageSha256.h | Add [[nodiscard]] to fulfillment methods |
| include/xrpl/conditions/Fulfillment.h | Add [[nodiscard]] to interface methods |
| include/xrpl/beast/utility/temp_dir.h | Add [[nodiscard]] to path helpers |
| include/xrpl/beast/utility/WrappedSink.h | Add [[nodiscard]] to Sink overrides |
| include/xrpl/beast/utility/PropertyStream.h | Add [[nodiscard]] to accessors |
| include/xrpl/beast/unit_test/thread.h | Add [[nodiscard]] to thread queries |
| include/xrpl/beast/unit_test/suite_info.h | Add [[nodiscard]] to accessors |
| include/xrpl/beast/unit_test/suite.h | Add [[nodiscard]] to what() |
| include/xrpl/beast/unit_test/runner.h | Add [[nodiscard]] to arg() |
| include/xrpl/beast/unit_test/results.h | Add [[nodiscard]] to accessors/counters |
| include/xrpl/beast/unit_test/recorder.h | Add [[nodiscard]] to report() |
| include/xrpl/beast/unit_test/detail/const_container.h | Add [[nodiscard]] to container queries/iterators |
| include/xrpl/beast/net/IPEndpoint.h | Add [[nodiscard]] to endpoint accessors |
| include/xrpl/beast/insight/Meter.h | Add [[nodiscard]] to impl() |
| include/xrpl/beast/insight/Hook.h | Add [[nodiscard]] to impl() |
| include/xrpl/beast/insight/Group.h | Add [[nodiscard]] to name() |
| include/xrpl/beast/insight/Gauge.h | Add [[nodiscard]] to impl() |
| include/xrpl/beast/insight/Event.h | Add [[nodiscard]] to impl() |
| include/xrpl/beast/core/SemanticVersion.h | Add [[nodiscard]] to helpers |
| include/xrpl/beast/core/LockFreeStack.h | Add [[nodiscard]] to empty() |
| include/xrpl/beast/core/List.h | Add [[nodiscard]] to iterators/accessors |
| include/xrpl/beast/container/detail/empty_base_optimization.h | Add [[nodiscard]] to member() |
| include/xrpl/beast/container/detail/aged_unordered_container.h | Add [[nodiscard]] to accessors |
| include/xrpl/beast/container/detail/aged_ordered_container.h | Add [[nodiscard]] to accessors |
| include/xrpl/beast/container/detail/aged_container_iterator.h | Add [[nodiscard]] to accessors |
| include/xrpl/beast/clock/manual_clock.h | Add [[nodiscard]] to now() |
| include/xrpl/beast/clock/abstract_clock.h | Add [[nodiscard]] to now() |
| include/xrpl/beast/asio/io_latency_probe.h | Add [[nodiscard]] to get_io_context() |
| include/xrpl/basics/base_uint.h | Add [[nodiscard]] to accessors/helpers |
| include/xrpl/basics/TaggedCache.h | Add [[nodiscard]] to entry state queries |
| include/xrpl/basics/Slice.h | Add [[nodiscard]] to accessors/iterators |
| include/xrpl/basics/SlabAllocator.h | Add [[nodiscard]] to size() |
| include/xrpl/basics/SharedWeakCachePointer.h | Add [[nodiscard]] to pointer queries |
| include/xrpl/basics/SHAMapHash.h | Add [[nodiscard]] to accessors/queries |
| include/xrpl/basics/Number.h | Add [[nodiscard]] to accessors/helpers |
| include/xrpl/basics/Mutex.hpp | Add [[nodiscard]] to get() accessor |
| include/xrpl/basics/Log.h | Add [[nodiscard]] to isOpen() |
| include/xrpl/basics/IntrusiveRefCounts.h | Add [[nodiscard]] to pack helper |
| include/xrpl/basics/IntrusivePointer.h | Add [[nodiscard]] to pointer queries |
| include/xrpl/basics/Expected.h | Add [[nodiscard]] to accessors |
| include/xrpl/basics/Buffer.h | Add [[nodiscard]] to accessors/iterators |
| .clang-tidy | Enable modernize-use-nodiscard |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 277 out of 277 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7015 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.0%
=========================================
Files 1010 1010
Lines 76304 76304
Branches 7479 7479
=========================================
- Hits 62529 62525 -4
- Misses 13775 13779 +4
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
godexsoft
added
the
Trivial
bthomee
approved these changes
Apr 24, 2026
godexsoft
added
the
Ready to merge
marek-foss-neti
pushed a commit
to marek-foss-neti/rippled
that referenced
this pull request
May 5, 2026
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR enables the
modernize-use-nodiscardcheck in clang-tidy automatically adding[[nodiscard]]where applicable.API Impact
No impact.