Sponsored Content
Skip to content

docs: Update hybrid offer invariant comment - #7007

Merged
bthomee merged 1 commit into
XRPLF:developfrom
Kassaking7:DEFI-611-comment-fix
Apr 24, 2026
Merged

docs: Update hybrid offer invariant comment#7007
bthomee merged 1 commit into
XRPLF:developfrom
Kassaking7:DEFI-611-comment-fix

Conversation

@Kassaking7

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This PR (#6716, to develop) contains confusing comment: The original code doesn't have any size check on sfAdditionalBooks

Rephrase the comment to have better readability. The comments follow the comment from this PR(#6945, to staging-313)

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@Kassaking7
Kassaking7 requested a review from bthomee April 23, 2026 20:02
@codecov

codecov Bot commented Apr 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.9%. Comparing base (7a449ed) to head (b30fac6).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #7007     +/-   ##
=========================================
- Coverage     81.9%   81.9%   -0.0%     
=========================================
  Files         1010    1010             
  Lines        76383   76383             
  Branches      7530    7530             
=========================================
- Hits         62522   62520      -2     
- Misses       13861   13863      +2     
Files with missing lines Coverage Δ
.../libxrpl/ledger/helpers/PermissionedDEXHelpers.cpp 96.6% <ø> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee bthomee changed the title chore: update comment for hybrid offer invariant chore: Update hybrid offer invariant comment Apr 24, 2026
@bthomee bthomee changed the title chore: Update hybrid offer invariant comment docs: Update hybrid offer invariant comment Apr 24, 2026
@Kassaking7 Kassaking7 added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Apr 24, 2026
@bthomee bthomee added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Apr 24, 2026
@bthomee
bthomee added this pull request to the merge queue Apr 24, 2026
Merged via the queue into XRPLF:develop with commit a6bd925 Apr 24, 2026
3 checks passed
marek-foss-neti pushed a commit to marek-foss-neti/rippled that referenced this pull request May 5, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants