style: Add bashate pre-commit hook to unify bash style - #6994
Merged
Conversation
mathbunnyru
commented
Apr 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds bashate to the repo’s pre-commit configuration to enforce consistent Bash formatting, and updates existing shell scripts to conform to the enforced style.
Changes:
- Add
bashateas a pre-commit hook (withE006ignored). - Reformat multiple
.shscripts to satisfy bashate’s style expectations (indentation /if ...; then/ loop formatting). - Minor whitespace alignment in Conan lockfile regeneration script.
Reviewed changes
Copilot reviewed 1 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.pre-commit-config.yaml |
Adds bashate hook to enforce consistent Bash style. |
conan/lockfile/regenerate.sh |
Aligns line continuations/indentation for conan lock create commands. |
bin/git/update-version.sh |
Reformat if block and command indentation for bashate compliance. |
bin/git/squash-branches.sh |
Reformat if/for blocks and indentation for bashate compliance. |
bin/git/setup-upstreams.sh |
Reformat conditional blocks/indentation for bashate compliance. |
.github/scripts/rename/namespace.sh |
Re-indent conditionals/loops for bashate compliance. |
.github/scripts/rename/include.sh |
Re-indent if body for bashate compliance. |
.github/scripts/rename/docs.sh |
Re-indent macOS gsed check for bashate compliance. |
.github/scripts/rename/definitions.sh |
Re-indent macOS gsed check for bashate compliance. |
.github/scripts/rename/copyright.sh |
Re-indent macOS gsed check and loop bodies for bashate compliance. |
.github/scripts/rename/config.sh |
Re-indent macOS gsed check and loop bodies for bashate compliance. |
.github/scripts/rename/cmake.sh |
Re-indent macOS gsed/ghead checks and conditional bodies for bashate compliance. |
.github/scripts/rename/binary.sh |
Re-indent macOS gsed check for bashate compliance. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6994 +/- ##
=========================================
- Coverage 82.5% 82.5% -0.0%
=========================================
Files 1010 1010
Lines 79246 79245 -1
Branches 7529 7528 -1
=========================================
- Hits 65389 65386 -3
- Misses 13857 13859 +2 🚀 New features to boost your workflow:
|
bthomee
approved these changes
Apr 22, 2026
marek-foss-neti
pushed a commit
to marek-foss-neti/rippled
that referenced
this pull request
May 5, 2026
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This adds
bashateto unify how we write bash files.Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)