fix: Address code review comments regarding boost::coroutine2 - #6977
Merged
Conversation
Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
pratikmankawde
added
the
DraftRunCI
pratikmankawde
commented
Apr 20, 2026
| boost/*:without_context=False | ||
| # Boost stacktrace fails to build with some sanitizers | ||
| boost/*:without_stacktrace=True | ||
| {% elif "thread" in sanitizers %} |
Contributor
Author
There was a problem hiding this comment.
TSAN is inactive at the moment, so this is just to keep the profile consistent. This is a dead branch at the moment.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6977 +/- ##
==========================================
+ Coverage 81.6% 82.6% +1.0%
==========================================
Files 1010 1012 +2
Lines 75992 98196 +22204
Branches 7605 10594 +2989
==========================================
+ Hits 62002 81112 +19110
- Misses 13990 16687 +2697
- Partials 0 397 +397
... and 380 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the codebase and build configuration to align with current Boost.Coroutine2 APIs and sanitizer-related Boost.Context build requirements.
Changes:
- Replace deprecated
boost::coroutines2::asymmetric_coroutineusage withboost::coroutines2::coroutineinJobQueue::Coro. - Centralize coroutine stack size into a named constant for clarity and reuse.
- Adjust build/config tooling: remove
BOOST_COROUTINES2_NO_DEPRECATION_WARNING, remove an ASAN-specific ConanfPICoverride, and add Boost.Context ucontext configuration for TSAN in the sanitizer profile.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| include/xrpl/core/Coro.ipp | Switch coroutine parameter type to boost::coroutines2::coroutine<void>::push_type and introduce a named stack-size constant. |
| conanfile.py | Removes ASAN-specific fPIC override (but leaves an inert SANITIZERS env check). |
| conan/profiles/sanitizers | Add TSAN-specific Boost.Context ucontext build flags for correct sanitizer annotations. |
| cmake/XrplInterface.cmake | Removes BOOST_COROUTINES2_NO_DEPRECATION_WARNING compile definition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pratikmankawde
marked this pull request as ready for review
April 29, 2026 16:10
pratikmankawde
changed the title
![xrplf-ai-reviewer[bot]](https://avatars.githubusercontent.com/u/67929741?s=60&v=4){kind=small}
bthomee
approved these changes
Apr 29, 2026
mathbunnyru
approved these changes
Apr 29, 2026
pratikmankawde
added
Ready to merge
bthomee
changed the title
boost::coroutine2
bthomee
enabled auto-merge
April 30, 2026 10:35
marek-foss-neti
pushed a commit
to marek-foss-neti/rippled
that referenced
this pull request
May 5, 2026
…F#6977) Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
…F#6977) Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Minor cleanup updates to boost::coroutine2 PR.
Context of Change
This PR does some minor cleanups. No logic changes.
#6372
Test Plan
Tested locally.