Sponsored Content
Skip to content

ci: Add workflow to check PR description has been filled - #6965

Merged
bthomee merged 1 commit into
XRPLF:developfrom
mathbunnyru:check_pr_desc
Apr 20, 2026
Merged

ci: Add workflow to check PR description has been filled#6965
bthomee merged 1 commit into
XRPLF:developfrom
mathbunnyru:check_pr_desc

Conversation

@mathbunnyru

@mathbunnyru mathbunnyru commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

We check that the PR description (ignoring HTML/MD comments) is not the same as in the base branch, so people should fill in the description.
This should also be made a required check.

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mathbunnyru
mathbunnyru requested a review from bthomee April 17, 2026 17:29
@mathbunnyru mathbunnyru added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Apr 17, 2026
@mathbunnyru

Copy link
Copy Markdown
Contributor Author

Works well - I checked that it fails with no changes or changes only inside comments and passes when the description is filled.

@mathbunnyru mathbunnyru added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Apr 17, 2026
@bthomee
bthomee added this pull request to the merge queue Apr 20, 2026
Merged via the queue into XRPLF:develop with commit 852fbe9 Apr 20, 2026
1 check passed
marek-foss-neti pushed a commit to marek-foss-neti/rippled that referenced this pull request May 5, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants