fix: Change AMMClawback return code to tecNO_PERMISSION - #6946
Conversation
![xrplf-ai-reviewer[bot]](https://avatars.githubusercontent.com/u/67929741?s=60&v=4){kind=small}
| jtx::testable_amendments() - featureSingleAssetVault - featureLendingProtocol; | ||
|
|
||
| testInvalidRequest(); | ||
| testInvalidRequest(all); |
There was a problem hiding this comment.
Should this be in the for loop below? Should we have such tests for all the AMM/DEX tests files?
There was a problem hiding this comment.
I don't think so. It doesn't need testing with other amendments disabled.
The following tests would have to be extended to test for featureMPTokenV2 disabled: AMM, AMMExtended, Check, Flow, Offer, Path. It's a lot of tests and might significantly increase the overall unit-tests execution time. It still might be worth doing. It'll be a lot of changes in these tests so it's worth having another PR.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6946 +/- ##
=========================================
- Coverage 81.6% 81.6% -0.0%
=========================================
Files 1010 1010
Lines 75973 75973
Branches 7610 7601 -9
=========================================
- Hits 61993 61991 -2
- Misses 13980 13982 +2
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
gregtatcam
added
the
Ready to merge
5 participants
High Level Overview of Change
Change AMMClawback return code to tecNO_PERMISSION on AllowTrustLineClawback and NoFreeze check.
Context of Change
Change tesSUCCESS to tecNO_PERMISSION.
Test Plan
Extend AMMClawback unit-test with featureMPTokensV2 disabled.