chore: Make pre-commit line ending conversions work on Windows - #6832
Merged
Conversation
* Remove the "mixed-line-ending" check, because prettier replaces it. * Pass "--end-of-line=auto" to prettier so that it will respect git's core.autocrlf setting, and do the right thing on each OS.
ximinez
added
the
Trivial
Collaborator
|
@ximinez I suppose we'll want this change also in the develop branch, and as soon as possible too for your sanity? |
bthomee
approved these changes
Apr 9, 2026
Contributor
Author
ximinez
added a commit
that referenced
this pull request
Apr 22, 2026
marek-foss-neti
pushed a commit
to marek-foss-neti/rippled
that referenced
this pull request
May 5, 2026
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Update pre-commit config to keep line endings correct across OSes.
core.autocrlf setting, and do the right thing on each OS.
Context of Change
Using the old settings, formatting a branch on Windows particularly using
pre-commit run -awould convert many files to have unix-style (LF) line endings. This undid the changes done by git'score.autocrlf=truesetting, and resulted in a large, bogus change set, plus many warnings along the lines ofwarning: in the working copy of 'README.md', LF will be replaced by CRLF the next time Git touches itin the output of most git commands.