Sponsored Content
Skip to content

refactor: Remove unused notTooManyOffers function from NFTokenUtils - #6737

Merged
ximinez merged 1 commit into
XRPLF:developfrom
Kassaking7:DEFI-616
Apr 13, 2026
Merged

refactor: Remove unused notTooManyOffers function from NFTokenUtils#6737
ximinez merged 1 commit into
XRPLF:developfrom
Kassaking7:DEFI-616

Conversation

@Kassaking7

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Remove unused notTooManyOffers Function from NFTokenUtils file

Context of Change

This function was forgotten to be deleted when we retired some NFT amendments

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@Kassaking7
Kassaking7 requested a review from yinyiqian1 April 8, 2026 16:29

@yinyiqian1 yinyiqian1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yinyiqian1 yinyiqian1 added the Needs additional review PR requires at least one more code review approval before it can be merged label Apr 8, 2026
@yinyiqian1
yinyiqian1 requested a review from shawnxie999 April 8, 2026 16:50
@codecov

codecov Bot commented Apr 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.5%. Comparing base (b0fe2ec) to head (2df2fc2).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6737   +/-   ##
=======================================
  Coverage     81.4%   81.5%           
=======================================
  Files         1006    1006           
  Lines        74463   74450   -13     
  Branches      7557    7548    -9     
=======================================
- Hits         60641   60640    -1     
+ Misses       13822   13810   -12     
Files with missing lines Coverage Δ
include/xrpl/ledger/helpers/NFTokenHelpers.h 100.0% <ø> (ø)
src/libxrpl/ledger/helpers/NFTokenHelpers.cpp 89.7% <ø> (+2.6%) ⬆️

... and 6 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kassaking7 Kassaking7 changed the title chore: remove unused notTooManyOffers Function from NFTokenUtils file chore: Remove unused notTooManyOffers Function from NFTokenUtils file Apr 8, 2026
@mvadari

mvadari commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

This should be refactor, not chore

@yinyiqian1 yinyiqian1 changed the title chore: Remove unused notTooManyOffers Function from NFTokenUtils file refactor: Remove unused notTooManyOffers Function from NFTokenUtils file Apr 8, 2026
@shawnxie999 shawnxie999 added Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. and removed Needs additional review PR requires at least one more code review approval before it can be merged labels Apr 13, 2026
@ximinez ximinez changed the title refactor: Remove unused notTooManyOffers Function from NFTokenUtils file refactor: Remove unused notTooManyOffers function from NFTokenUtils file Apr 13, 2026
@ximinez ximinez changed the title refactor: Remove unused notTooManyOffers function from NFTokenUtils file refactor: Remove unused notTooManyOffers function from NFTokenUtils Apr 13, 2026
@ximinez
ximinez enabled auto-merge April 13, 2026 23:17
@ximinez
ximinez added this pull request to the merge queue Apr 13, 2026
Merged via the queue into XRPLF:develop with commit 61fbde3 Apr 13, 2026
3 checks passed
shortthefomo pushed a commit to shortthefomo/rippled that referenced this pull request Apr 14, 2026
shortthefomo pushed a commit to shortthefomo/rippled that referenced this pull request Apr 15, 2026
marek-foss-neti pushed a commit to marek-foss-neti/rippled that referenced this pull request May 5, 2026
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants