ci: Change conditions for uploading artifacts in public/private/org repos - #6734
Merged
Conversation
mathbunnyru
commented
Apr 7, 2026
|
|
||
| deploy: | ||
| if: ${{ (github.repository_owner == 'XRPLF' || github.event.repository.visibility == 'public') && github.event_name == 'push' }} | ||
| if: ${{ github.repository == 'XRPLF/rippled' && github.event_name == 'push' }} |
Contributor
Author
There was a problem hiding this comment.
Condition here is different than the previous one - we can use actions/upload-pages-artifact on any public repo, but we have only configured pages for this repo, that's why here we restrict it for a repo
mathbunnyru
added
Trivial
bthomee
approved these changes
Apr 7, 2026
bthomee
enabled auto-merge
April 7, 2026 14:20
bthomee
disabled auto-merge
April 7, 2026 14:20
bthomee
changed the title
bthomee
enabled auto-merge
April 7, 2026 14:21
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6734 +/- ##
=========================================
- Coverage 81.4% 81.4% -0.0%
=========================================
Files 1006 1006
Lines 74463 74463
Branches 7562 7558 -4
=========================================
- Hits 60641 60639 -2
- Misses 13822 13824 +2 see 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
mvadari
pushed a commit
that referenced
this pull request
Apr 7, 2026
abrahim-djordjevic
pushed a commit
to abrahim-djordjevic/rippled
that referenced
this pull request
Apr 7, 2026
marek-foss-neti
pushed a commit
to marek-foss-neti/rippled
that referenced
this pull request
May 5, 2026
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
We can still exhaust artifact storage on the private repo in the org, so we'll have to only upload in public repos.
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)