Add delegation tests for Confidential Transfers - #6729
Merged
yinyiqian1 merged 2 commits intoApr 7, 2026
Merged
Conversation
yinyiqian1
force-pushed
the
confidential-delegation
branch
from
April 6, 2026 22:02
d4b2a6e to
bdb455a
Compare
yinyiqian1
force-pushed
the
confidential-delegation
branch
from
April 6, 2026 22:08
bdb455a to
8f54e4b
Compare
yinyiqian1
marked this pull request as ready for review
April 6, 2026 22:09
yinyiqian1
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ripple/confidential-transfer #6729 +/- ##
============================================================
Coverage 81.7% 81.7%
============================================================
Files 1023 1023
Lines 75724 75714 -10
Branches 7556 7553 -3
============================================================
- Hits 61873 61866 -7
+ Misses 13851 13848 -3 see 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
shawnxie999
reviewed
Apr 7, 2026
Comment on lines
+547
to
+553
| if (ticketSeq && delegateAcct) | ||
| env_( | ||
| jv, | ||
| expectedFlags, | ||
| expectedTer, | ||
| ticket::use(*ticketSeq), | ||
| delegate::as(*delegateAcct)); |
Contributor
There was a problem hiding this comment.
do we have a test of delegation using tickets?
Contributor
Author
There was a problem hiding this comment.
Good catch, I'll create a separate PR for delegation+ticket
shawnxie999
approved these changes
Apr 7, 2026
yinyiqian1
merged commit Apr 7, 2026
0d7bf69
into
XRPLF:ripple/confidential-transfer
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tests
confidential transfer + delegationHigh Level Overview of Change
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)