Sponsored Content
Skip to content

chore: Use nudb recipe from the upstream - #6701

Merged
bthomee merged 2 commits into
XRPLF:developfrom
mathbunnyru:no_custom_nudb
Apr 1, 2026
Merged

chore: Use nudb recipe from the upstream#6701
bthomee merged 2 commits into
XRPLF:developfrom
mathbunnyru:no_custom_nudb

Conversation

@mathbunnyru

Copy link
Copy Markdown
Contributor

High Level Overview of Change

My PR upstream has been merged, so now there is no reason to use custom nudb recipe.
conan-io/conan-center-index#29849

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mathbunnyru
mathbunnyru requested a review from bthomee April 1, 2026 09:39
@mathbunnyru mathbunnyru added Trivial Simple change with minimal effect, or already tested. Only needs one approval. Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. labels Apr 1, 2026
@codecov

codecov Bot commented Apr 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.5%. Comparing base (a9afd2c) to head (331a04a).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6701     +/-   ##
=========================================
- Coverage     81.5%   81.5%   -0.0%     
=========================================
  Files          999     999             
  Lines        74458   74458             
  Branches      7553    7550      -3     
=========================================
- Hits         60652   60649      -3     
- Misses       13806   13809      +3     

see 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bthomee
bthomee added this pull request to the merge queue Apr 1, 2026
Merged via the queue into XRPLF:develop with commit b6aa4a8 Apr 1, 2026
3 checks passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants