Sponsored Content
Skip to content

ci: Use pull_request_target to check for signed commits - #6697

Merged
bthomee merged 1 commit into
XRPLF:developfrom
mathbunnyru:sign_commits_target
Mar 31, 2026
Merged

ci: Use pull_request_target to check for signed commits#6697
bthomee merged 1 commit into
XRPLF:developfrom
mathbunnyru:sign_commits_target

Conversation

@mathbunnyru

Copy link
Copy Markdown
Contributor

High Level Overview of Change

This should make commenting work even for PRs made from forks

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mathbunnyru
mathbunnyru requested a review from bthomee March 31, 2026 17:02
@mathbunnyru mathbunnyru added Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval. labels Mar 31, 2026
@bthomee
bthomee added this pull request to the merge queue Mar 31, 2026
Merged via the queue into XRPLF:develop with commit c3fae84 Mar 31, 2026
1 check passed
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants