Sponsored Content
Skip to content

fix: Fix previous ledger size typo in RCLConsensus - #6696

Merged
bthomee merged 3 commits into
developfrom
mvadari/fix-prev-ledger-size
Mar 31, 2026
Merged

fix: Fix previous ledger size typo in RCLConsensus#6696
bthomee merged 3 commits into
developfrom
mvadari/fix-prev-ledger-size

Conversation

@mvadari

@mvadari mvadari commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Title pretty much says it all

Context of Change

AI review

API Impact

N/A

@mvadari
mvadari requested a review from bthomee March 31, 2026 16:22
@mvadari mvadari added the AI Triage Bugs and fixes that have been triaged via AI initiatives label Mar 31, 2026

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Opus 4.6 · Prompt: V12

@codecov

codecov Bot commented Mar 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.4%. Comparing base (2502bef) to head (5b7e017).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/xrpld/app/consensus/RCLConsensus.cpp 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #6696     +/-   ##
=========================================
- Coverage     81.5%   81.4%   -0.0%     
=========================================
  Files          999     999             
  Lines        74458   74458             
  Branches      7553    7553             
=========================================
- Hits         60653   60646      -7     
- Misses       13805   13812      +7     
Files with missing lines Coverage Δ
src/xrpld/app/consensus/RCLConsensus.cpp 59.2% <0.0%> (ø)

... and 4 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Mar 31, 2026
@bthomee bthomee added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 31, 2026
@bthomee
bthomee added this pull request to the merge queue Mar 31, 2026
Merged via the queue into develop with commit a9afd2c Mar 31, 2026
2 of 3 checks passed
@bthomee
bthomee deleted the mvadari/fix-prev-ledger-size branch March 31, 2026 20:13
@mvadari mvadari added this to the 3.2.0 milestone May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Triage Bugs and fixes that have been triaged via AI initiatives Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants