Sponsored Content
Skip to content

fix: Remove fatal assertion on Linux thread name truncation - #6690

Merged
bthomee merged 4 commits into
developfrom
vlntb/thread-name-as-log
Apr 1, 2026
Merged

fix: Remove fatal assertion on Linux thread name truncation #6690
bthomee merged 4 commits into
developfrom
vlntb/thread-name-as-log

Conversation

@vlntb

@vlntb vlntb commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Fixes a crash in DEBUG builds when thread names exceed Linux's 15-character limit.

Context of Change

  1. Removed fatal assertion in CurrentThreadName.cpp
  2. Fixed OrderBook job naming in OrderBookDBImpl.cpp

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@vlntb
vlntb marked this pull request as ready for review March 31, 2026 14:52
@vlntb
vlntb requested review from bthomee and vvysokikh1 March 31, 2026 14:58

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Opus 4.6 · Prompt: V12

@codecov

codecov Bot commented Mar 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.4%. Comparing base (29e49ab) to head (34d8fdc).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/xrpld/app/ledger/OrderBookDBImpl.cpp 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6690   +/-   ##
=======================================
  Coverage     81.4%   81.4%           
=======================================
  Files          999     999           
  Lines        74424   74423    -1     
  Branches      7553    7552    -1     
=======================================
+ Hits         60605   60606    +1     
+ Misses       13819   13817    -2     
Files with missing lines Coverage Δ
src/libxrpl/beast/core/CurrentThreadName.cpp 81.8% <ø> (+6.8%) ⬆️
src/xrpld/app/ledger/OrderBookDBImpl.cpp 78.9% <0.0%> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vlntb vlntb added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Apr 1, 2026
@bthomee
bthomee enabled auto-merge April 1, 2026 16:41
@bthomee
bthomee added this pull request to the merge queue Apr 1, 2026
Merged via the queue into develop with commit 6e24522 Apr 1, 2026
2 of 3 checks passed
@bthomee
bthomee deleted the vlntb/thread-name-as-log branch April 1, 2026 17:17
@ximinez ximinez modified the milestones: 3.1.3, 3.1.3 (develop) Apr 15, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants