chore: Fix clang-tidy header filter - #6686
Merged
Merged
Conversation
godexsoft
added
the
Trivial
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6686 +/- ##
=========================================
- Coverage 81.5% 81.4% -0.0%
=========================================
Files 999 999
Lines 74456 74456
Branches 7559 7575 +16
=========================================
- Hits 60653 60623 -30
- Misses 13803 13833 +30 see 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
kuznetsss
approved these changes
Mar 30, 2026
godexsoft
added
the
Ready to merge
bthomee
pushed a commit
that referenced
this pull request
Mar 30, 2026
bthomee
pushed a commit
that referenced
this pull request
Mar 30, 2026
beartec-jpg
pushed a commit
to beartec-jpg/FalconLedger
that referenced
this pull request
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Turns out the header filter was commented out which leads to clang-tidy processing less code than we want to, skipping many of the headers. This PR fixes the configuration such that clang-tidy runs against more of our code.
In previous PRs we have fixed multiple checks for all .cpp files, now we will have to fix some of them again but for all remaining .h files that were previously ignored.
API Impact
No impact.