Sponsored Content
Skip to content

chore: Shorten job names to stay within Linux 15-char thread limit - #6669

Merged
bthomee merged 1 commit into
developfrom
vlntb/thread-orderbookupd-name-too-long
Mar 26, 2026
Merged

chore: Shorten job names to stay within Linux 15-char thread limit#6669
bthomee merged 1 commit into
developfrom
vlntb/thread-orderbookupd-name-too-long

Conversation

@vlntb

@vlntb vlntb commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Linux limits thread names to 15 characters (plus null terminator). Job names that include ledger sequences were exceeding this limit, causing assertion failures.

Dynamic job names constructed with ledger sequences (e.g., "OrderBookUpd" + seq) can exceed 15 characters as ledger numbers grow.

Fixes:

  1. OrderBookDBImpl.cpp:61 - Shortened prefix from "OrderBookUpd" (13 chars) to "OBUpd" (5 chars)
  2. LedgerPersistence.cpp:75 - Added prefix "Pub" (3 chars) to bare sequence numbers

Result: Both job names now guaranteed to stay within 15-character limit:

  • "OBUpd" + seq: max 15 chars (supports up to 10-digit sequences)
  • "Pub" + seq: max 15 chars (supports up to 12-digit sequences)

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@vlntb
vlntb requested review from a1q123456 and vvysokikh1 March 26, 2026 11:15

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Opus 4.6 · Prompt: V12

@codecov

codecov Bot commented Mar 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.5%. Comparing base (2c765f6) to head (272cc17).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/xrpld/app/ledger/OrderBookDBImpl.cpp 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6669   +/-   ##
=======================================
  Coverage     81.4%   81.5%           
=======================================
  Files          998     998           
  Lines        74443   74443           
  Branches      7563    7558    -5     
=======================================
+ Hits         60632   60634    +2     
+ Misses       13811   13809    -2     
Files with missing lines Coverage Δ
src/xrpld/app/ledger/detail/LedgerPersistence.cpp 83.3% <100.0%> (ø)
src/xrpld/app/ledger/OrderBookDBImpl.cpp 78.9% <0.0%> (ø)

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/xrpld/app/ledger/OrderBookDBImpl.cpp
@vlntb vlntb changed the title Shorten job names to stay within Linux 15-char thread limit chore: Shorten job names to stay within Linux 15-char thread limit Mar 26, 2026
@vlntb vlntb added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 26, 2026
@vvysokikh1
vvysokikh1 removed their request for review March 26, 2026 13:50
@bthomee
bthomee added this pull request to the merge queue Mar 26, 2026
Merged via the queue into develop with commit faf69da Mar 26, 2026
2 of 3 checks passed
@bthomee
bthomee deleted the vlntb/thread-orderbookupd-name-too-long branch March 26, 2026 14:28
@ximinez ximinez modified the milestones: 3.2.0, 3.1.3, 3.1.3 (develop) Apr 15, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants