Sponsored Content
Skip to content

fix: Improve loan invariant message - #6668

Merged
bthomee merged 1 commit into
developfrom
tapanito/lending-trivial-fixes
Mar 26, 2026
Merged

fix: Improve loan invariant message#6668
bthomee merged 1 commit into
developfrom
tapanito/lending-trivial-fixes

Conversation

@Tapanito

Copy link
Copy Markdown
Contributor

High Level Overview of Change

Note, there are no unit-tests to update. These will come later, as part of Lending 1.1.

Changing a log message does not require an amendment.

Context of Change

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@Tapanito
Tapanito requested a review from bthomee March 26, 2026 10:26
@Tapanito Tapanito added Trivial Simple change with minimal effect, or already tested. Only needs one approval. AI Triage Bugs and fixes that have been triaged via AI initiatives labels Mar 26, 2026

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found. Code looks good!

Review by Claude Opus 4.6 · Prompt: V12

Comment thread src/libxrpl/tx/invariants/LoanInvariant.cpp
@codecov

codecov Bot commented Mar 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.4%. Comparing base (2c765f6) to head (3de5a5a).
⚠️ Report is 46 commits behind head on develop.

Files with missing lines Patch % Lines
src/libxrpl/tx/invariants/LoanInvariant.cpp 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6668   +/-   ##
=======================================
  Coverage     81.4%   81.4%           
=======================================
  Files          998     998           
  Lines        74443   74442    -1     
  Branches      7563    7558    -5     
=======================================
  Hits         60632   60632           
+ Misses       13811   13810    -1     
Files with missing lines Coverage Δ
src/libxrpl/tx/invariants/LoanInvariant.cpp 83.2% <0.0%> (+0.7%) ⬆️

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Tapanito Tapanito added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Mar 26, 2026
@bthomee
bthomee added this pull request to the merge queue Mar 26, 2026
Merged via the queue into develop with commit 76e3b4f Mar 26, 2026
2 of 3 checks passed
@bthomee
bthomee deleted the tapanito/lending-trivial-fixes branch March 26, 2026 12:58
bthomee pushed a commit that referenced this pull request Mar 30, 2026
bthomee pushed a commit that referenced this pull request Mar 30, 2026
ximinez pushed a commit that referenced this pull request Apr 1, 2026
@ximinez ximinez mentioned this pull request Apr 1, 2026
ximinez pushed a commit that referenced this pull request Apr 1, 2026
@ximinez ximinez added this to the 3.1.3 milestone Apr 15, 2026
@ximinez ximinez modified the milestones: 3.1.3, 3.1.3 (develop) Apr 15, 2026
@mvadari mvadari modified the milestones: 3.1.3 (develop), 3.2.0 May 20, 2026
beartec-jpg pushed a commit to beartec-jpg/FalconLedger that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Triage Bugs and fixes that have been triaged via AI initiatives Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. Trivial Simple change with minimal effect, or already tested. Only needs one approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants